Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(467)

Unified Diff: tools/telemetry/telemetry/page/page_runner_unittest.py

Issue 390233002: Kill AddError/AddErrorMessage from PageTestResults. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/page/page_runner_unittest.py
diff --git a/tools/telemetry/telemetry/page/page_runner_unittest.py b/tools/telemetry/telemetry/page/page_runner_unittest.py
index 5797c75e4984366e75f21a801349485719004301..f5b15f13cb1bc1a1b55e59662b090e00ed3c8049 100644
--- a/tools/telemetry/telemetry/page/page_runner_unittest.py
+++ b/tools/telemetry/telemetry/page/page_runner_unittest.py
@@ -76,8 +76,7 @@ class PageRunnerTests(unittest.TestCase):
SetUpPageRunnerArguments(options)
results = page_runner.Run(Test(), ps, expectations, options)
self.assertEquals(0, len(results.successes))
- self.assertEquals(0, len(results.failures))
- self.assertEquals(1, len(results.errors))
+ self.assertEquals(1, len(results.failures))
def testHandlingOfTestThatRaisesWithNonFatalUnknownExceptions(self):
ps = page_set.PageSet()
@@ -127,7 +126,6 @@ class PageRunnerTests(unittest.TestCase):
Test(), ps, expectations, options)
self.assertEquals(1, len(results.successes))
self.assertEquals(0, len(results.failures))
- self.assertEquals(0, len(results.errors))
def testRetryOnBrowserCrash(self):
ps = page_set.PageSet()
@@ -150,7 +148,6 @@ class PageRunnerTests(unittest.TestCase):
self.assertEquals(1, len(results.successes))
self.assertEquals(0, len(results.failures))
- self.assertEquals(0, len(results.errors))
@decorators.Disabled('xp') # Flaky, http://crbug.com/390079.
def testDiscardFirstResult(self):
@@ -476,7 +473,6 @@ class PageRunnerTests(unittest.TestCase):
self.assertFalse(test.will_navigate_to_page_called)
self.assertEquals(0, len(results.successes))
self.assertEquals(0, len(results.failures))
- self.assertEquals(0, len(results.errors))
def TestUseLiveSitesFlag(self, options, expect_from_archive):
ps = page_set.PageSet(

Powered by Google App Engine
This is Rietveld 408576698