Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(729)

Unified Diff: content/test/gpu/gpu_tests/webgl_conformance.py

Issue 390233002: Kill AddError/AddErrorMessage from PageTestResults. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/test/gpu/gpu_tests/webgl_conformance.py
diff --git a/content/test/gpu/gpu_tests/webgl_conformance.py b/content/test/gpu/gpu_tests/webgl_conformance.py
index 8deaf7ed0dc2bb5629fec956f17d5d518601fdf6..b09282d7a7252aa4109a951fa77b186ae3c78fee 100644
--- a/content/test/gpu/gpu_tests/webgl_conformance.py
+++ b/content/test/gpu/gpu_tests/webgl_conformance.py
@@ -69,7 +69,7 @@ def _WebGLTestMessages(tab):
class WebglConformanceValidator(page_test.PageTest):
def __init__(self):
- super(WebglConformanceValidator, self).__init__(attempts=1, max_errors=10)
Ken Russell (switch to Gerrit) 2014/07/15 00:20:20 What's the side-effect of this change? The maximum
nduca 2014/07/15 02:03:28 is it important to distinguish between errors and
Ken Russell (switch to Gerrit) 2014/07/15 04:42:18 No (Brandon, Mo, correct me if I'm wrong), but it
chrishenry 2014/07/15 17:55:52 Previously this test doesn't clamp down on number
+ super(WebglConformanceValidator, self).__init__(attempts=1)
def ValidatePage(self, page, tab, results):
if not _DidWebGLTestSucceed(tab):
« no previous file with comments | « no previous file | tools/telemetry/telemetry/benchmark.py » ('j') | tools/telemetry/telemetry/page/profile_generator.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698