Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Unified Diff: tools/telemetry/telemetry/value/summary.py

Issue 390233002: Kill AddError/AddErrorMessage from PageTestResults. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase and simplify unit test a bit. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/telemetry/telemetry/results/page_test_results_unittest.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/value/summary.py
diff --git a/tools/telemetry/telemetry/value/summary.py b/tools/telemetry/telemetry/value/summary.py
index 82ba0965cd7dace81055fa19b8a4c56d613ed367..71369fcfd037cfe80eaa47461d0f95edf44f857a 100644
--- a/tools/telemetry/telemetry/value/summary.py
+++ b/tools/telemetry/telemetry/value/summary.py
@@ -32,8 +32,8 @@ class Summary(object):
]
"""
- def __init__(self, all_page_specific_values, had_errors_or_failures):
- self.had_errors_or_failures = had_errors_or_failures
+ def __init__(self, all_page_specific_values, had_failures):
+ self.had_failures = had_failures
self._computed_per_page_values = []
self._computed_summary_values = []
self._interleaved_computed_per_page_values_and_summaries = []
@@ -100,7 +100,7 @@ class Summary(object):
# value name so that we can find them when printing out value names in
# alphabetical order.
merged_pages_value_by_value_name = {}
- if not self.had_errors_or_failures:
+ if not self.had_failures:
for value in merge_values.MergeLikeValuesFromDifferentPages(
all_successful_page_values):
assert value.name not in merged_pages_value_by_value_name
@@ -142,7 +142,7 @@ class Summary(object):
# Note: this branch is structured less-densely to improve legibility.
if num_successful_pages_for_this_value_name > 1:
should_print = True
- elif (self.had_errors_or_failures and
+ elif (self.had_failures and
num_successful_pages_for_this_value_name == 1):
should_print = True
else:
« no previous file with comments | « tools/telemetry/telemetry/results/page_test_results_unittest.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698