tools/telemetry/telemetry/results/page_test_results_unittest.py - Issue 390233002: Kill AddError/AddErrorMessage from PageTestResults.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/results/page_test_results_unittest.py

Issue 390233002: Kill AddError/AddErrorMessage from PageTestResults. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase and simplify unit test a bit. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/telemetry/telemetry/results/page_test_results_unittest.py

diff --git a/tools/telemetry/telemetry/results/page_test_results_unittest.py b/tools/telemetry/telemetry/results/page_test_results_unittest.py

index 482d02077c1ded8c3928d1018c61c044309185f4..42dde5965e731468cf8f32fa098a73af0dca8a61 100644

--- a/tools/telemetry/telemetry/results/page_test_results_unittest.py

+++ b/tools/telemetry/telemetry/results/page_test_results_unittest.py

@@ -33,20 +33,3 @@ class PageTestResultsTest(base_test_results_unittest.BaseTestResultsUnittest):

self.assertEquals(results.pages_that_had_failures,

set([self.pages[0]]))

self.assertEquals(results.successes, [self.pages[1]])

- def test_errors(self):

- results = NonPrintingPageTestResults()

- results.AddError(self.pages[0], self.CreateException())

- results.AddSuccess(self.pages[1])

- self.assertEquals(results.pages_that_had_errors,

- set([self.pages[0]]))

- self.assertEquals(results.successes, [self.pages[1]])

- def test_errors_and_failures(self):

- results = NonPrintingPageTestResults()

- results.AddError(self.pages[0], self.CreateException())

- results.AddError(self.pages[1], self.CreateException())

- results.AddSuccess(self.pages[2])

- self.assertEquals(results.pages_that_had_errors_or_failures,

- set([self.pages[0], self.pages[1]]))

- self.assertEquals(results.successes, [self.pages[2]])