tools/telemetry/telemetry/page/profile_generator.py - Issue 390233002: Kill AddError/AddErrorMessage from PageTestResults.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/page/profile_generator.py

Issue 390233002: Kill AddError/AddErrorMessage from PageTestResults. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase and simplify unit test a bit. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/telemetry/telemetry/page/profile_generator.py

diff --git a/tools/telemetry/telemetry/page/profile_generator.py b/tools/telemetry/telemetry/page/profile_generator.py

index 12b6011b0c91e77c0632c62fab7f12de54f99737..979ece9bd2bf72b731aaf896cd2471604a78496e 100644

--- a/tools/telemetry/telemetry/page/profile_generator.py

+++ b/tools/telemetry/telemetry/page/profile_generator.py

@@ -46,11 +46,10 @@ def GenerateProfiles(profile_creator_class, profile_creator_name, options):

results = page_runner.Run(test, test.page_set, expectations, options)

- if results.errors or results.failures:

+ if results.failures:

logging.warning('Some pages failed.')

- if results.errors or results.failures:

- logging.warning('Failed pages:\n%s',

- '\n'.join(zip(*results.errors + results.failures)[0]))

+ logging.warning('Failed pages:\n%s',

+ '\n'.join(zip(*results.failures)[0]))

return 1

# Everything is a-ok, move results to final destination.