Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Unified Diff: tools/telemetry/telemetry/page/page_test.py

Issue 390233002: Kill AddError/AddErrorMessage from PageTestResults. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase and simplify unit test a bit. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/page/page_test.py
diff --git a/tools/telemetry/telemetry/page/page_test.py b/tools/telemetry/telemetry/page/page_test.py
index 60912a89172e180ed9c0c26b53b5361742fd9945..cb76630b7a18dea3692f07fb1d3edcd9558e0a62 100644
--- a/tools/telemetry/telemetry/page/page_test.py
+++ b/tools/telemetry/telemetry/page/page_test.py
@@ -31,7 +31,6 @@ class PageTest(command_line.Command):
clear_cache_before_each_run=False,
attempts=3,
max_failures=None,
- max_errors=None,
is_action_name_to_run_optional=False):
super(PageTest, self).__init__()
@@ -49,7 +48,6 @@ class PageTest(command_line.Command):
self._close_tabs_before_run = True
self._attempts = attempts
self._max_failures = max_failures
- self._max_errors = max_errors
self._is_action_name_to_run_optional = is_action_name_to_run_optional
assert self._attempts > 0, 'Test attempts must be greater than 0'
# If the test overrides the TabForPage method, it is considered a multi-tab
@@ -112,15 +110,6 @@ class PageTest(command_line.Command):
def max_failures(self, count):
self._max_failures = count
- @property
- def max_errors(self):
- """Maximum number of errors allowed for the page set."""
- return self._max_errors
-
- @max_errors.setter
- def max_errors(self, count):
- self._max_errors = count
-
def Run(self, args):
# Define this method to avoid pylint errors.
# TODO(dtu): Make this actually run the test with args.page_set.
« no previous file with comments | « tools/telemetry/telemetry/page/page_runner_unittest.py ('k') | tools/telemetry/telemetry/page/profile_generator.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698