Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 390193002: add set_acl() and get_acl() to gs_utils.py (Closed)

Created:
6 years, 5 months ago by epoger
Modified:
6 years, 5 months ago
Reviewers:
rmistry
CC:
reviews_skia.org, borenet
Base URL:
https://skia.googlesource.com/common.git@master
Visibility:
Public.

Description

add set_acl() and get_acl() to gs_utils.py As needed for uploading SKPs and their renderings (see bug 2732) BUG=skia:2732 R=rmistry@google.com Committed: https://skia.googlesource.com/common/+/773df58

Patch Set 1 #

Patch Set 2 : little fixes #

Patch Set 3 : handle overwriting a permission with the same id_type/id_value #

Total comments: 6

Patch Set 4 : rename add_acl(), delete delete_acl(), etc. #

Patch Set 5 : move set_acl() below get_acl() #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+155 lines, -3 lines) Patch
M py/utils/gs_utils.py View 1 2 3 4 4 chunks +155 lines, -3 lines 1 comment Download

Messages

Total messages: 8 (0 generated)
epoger
Ravi- please review at patchset 2.
6 years, 5 months ago (2014-07-14 22:01:13 UTC) #1
epoger
Made one more little fix in patchset 3. Awaiting review.
6 years, 5 months ago (2014-07-15 02:28:05 UTC) #2
rmistry
Exciting stuff https://codereview.chromium.org/390193002/diff/60001/py/utils/gs_utils.py File py/utils/gs_utils.py (right): https://codereview.chromium.org/390193002/diff/60001/py/utils/gs_utils.py#newcode173 py/utils/gs_utils.py:173: for entry in matching_entries: Is it possible ...
6 years, 5 months ago (2014-07-15 11:26:10 UTC) #3
epoger
Thanks for the questions. Notes for live discussion below... https://codereview.chromium.org/390193002/diff/60001/py/utils/gs_utils.py File py/utils/gs_utils.py (right): https://codereview.chromium.org/390193002/diff/60001/py/utils/gs_utils.py#newcode173 py/utils/gs_utils.py:173: ...
6 years, 5 months ago (2014-07-15 13:20:18 UTC) #4
epoger
More notes from live discussion... I will create another revision and send it out for ...
6 years, 5 months ago (2014-07-15 13:34:26 UTC) #5
epoger
Ravi- PTAL at changes in patchsets 4+5, which I think address the issues we discussed. ...
6 years, 5 months ago (2014-07-15 19:47:04 UTC) #6
rmistry
LGTM
6 years, 5 months ago (2014-07-16 10:20:54 UTC) #7
epoger
6 years, 5 months ago (2014-07-16 12:56:30 UTC) #8
Message was sent while issue was closed.
Committed patchset #5 manually as r773df58 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698