MacViews: Move TranslateClient's InfoBar stub for toolkit-views to a static function in c/b/ui

MacViews: Exclude the toolkit-views TranslateClient InfoBar stub on Mac

The Translate UI is moving from a InfoBar to a bubble. Mac still uses
the InfoBar but on other views platforms, it is replaced by a stub which
MacViews isn't ready to use.

BUG=390755, 276181
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283500

[tapted, 2014-07-15 12:15:18]

hajimehoshi - please review for c/b/translate
pkasting - please review for c/b/ui/*/infobars

[Peter Kasting, 2014-07-15 19:09:42]

If the issue is that Mac still has code in translate_infobar_base.mm, and it
wants to use that implementation, why can't you just change the #if if
chrome_translate_client.cc to be "#if defined(TOOLKIT_VIEWS) &&
!defined(OS_MACOSX)"?

[tapted, 2014-07-15 22:07:34]

On 2014/07/15 19:09:42, Peter Kasting wrote:
> If the issue is that Mac still has code in translate_infobar_base.mm, and it
> wants to use that implementation, why can't you just change the #if if
> chrome_translate_client.cc to be "#if defined(TOOLKIT_VIEWS) &&
> !defined(OS_MACOSX)"?

For MacViews we want to port things over gradually. Unlike a switch directly to
Aura, we have the opportunity to do a toolkit_views=1 Chrome build that
initially just runs all the existing Cocoa UI. (And this is actually now pretty
close - basically this and crrev.com/393763002, crrev.com/375843002 will do it)

But for this, we need to ensure that chrome_browser with toolkit_views=1 works
for the Cocoa chrome_browser_ui component -- method signatures need to match and
no symbol dupes. For some things we should even be able to introduce some of the
views UI on mac between a chrome://flag, with bits from both ui components.

[Peter Kasting, 2014-07-15 22:09:22]

On 2014/07/15 22:07:34, tapted wrote:
> On 2014/07/15 19:09:42, Peter Kasting wrote:
> > If the issue is that Mac still has code in translate_infobar_base.mm, and it
> > wants to use that implementation, why can't you just change the #if if
> > chrome_translate_client.cc to be "#if defined(TOOLKIT_VIEWS) &&
> > !defined(OS_MACOSX)"?
> 
> For MacViews we want to port things over gradually. Unlike a switch directly
to
> Aura, we have the opportunity to do a toolkit_views=1 Chrome build that
> initially just runs all the existing Cocoa UI. (And this is actually now
pretty
> close - basically this and crrev.com/393763002, crrev.com/375843002 will do
it)
> 
> But for this, we need to ensure that chrome_browser with toolkit_views=1 works
> for the Cocoa chrome_browser_ui component -- method signatures need to match
and
> no symbol dupes. For some things we should even be able to introduce some of
the
> views UI on mac between a chrome://flag, with bits from both ui components.

I don't understand how any of that answers my question.  The proposal I just
gave was supposed to ensure "method signatures match and no symbol dupes".  Why
doesn't it?

[tapted, 2014-07-15 22:43:43]

On 2014/07/15 22:09:22, Peter Kasting wrote:
> On 2014/07/15 22:07:34, tapted wrote:
> > On 2014/07/15 19:09:42, Peter Kasting wrote:
> > > If the issue is that Mac still has code in translate_infobar_base.mm, and
it
> > > wants to use that implementation, why can't you just change the #if if
> > > chrome_translate_client.cc to be "#if defined(TOOLKIT_VIEWS) &&
> > > !defined(OS_MACOSX)"?
> > 
> > For MacViews we want to port things over gradually. Unlike a switch directly
> to
> > Aura, we have the opportunity to do a toolkit_views=1 Chrome build that
> > initially just runs all the existing Cocoa UI. (And this is actually now
> pretty
> > close - basically this and crrev.com/393763002, crrev.com/375843002 will do
> it)
> > 
> > But for this, we need to ensure that chrome_browser with toolkit_views=1
works
> > for the Cocoa chrome_browser_ui component -- method signatures need to match
> and
> > no symbol dupes. For some things we should even be able to introduce some of
> the
> > views UI on mac between a chrome://flag, with bits from both ui components.
> 
> I don't understand how any of that answers my question.  The proposal I just
> gave was supposed to ensure "method signatures match and no symbol dupes". 
Why
> doesn't it?

Sorry - I must have spent too long thinking about this one :/. You're right -
for this case, it does work. I'm happy with an #ifdef change here for now. I
think the only downside is that the #ifdef will need to change again when
porting this part of the UI on Mac to use views (i.e. can't be achieved by
shuffling things around in gyp files). It makes this case the odd-one-out in
this respect, but if this UI is feasible to have both built and switch with a
chrome://flag it will need to change anyway.

I've updated the CL - PTAL.

[Peter Kasting, 2014-07-15 23:20:45]

LGTM

[hajimehoshi, 2014-07-16 03:24:18]

lgtm

[tapted, 2014-07-16 03:43:22]

The CQ bit was checked by tapted@chromium.org

[commit-bot: I haz the power, 2014-07-16 03:49:04]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tapted@chromium.org/390183007/100001

[commit-bot: I haz the power, 2014-07-16 07:07:46]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[commit-bot: I haz the power, 2014-07-16 07:30:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-16 07:30:56]

Try jobs failed on following builders:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[tapted, 2014-07-16 07:32:41]

The CQ bit was checked by tapted@chromium.org

[commit-bot: I haz the power, 2014-07-16 07:33:56]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tapted@chromium.org/390183007/100001

[commit-bot: I haz the power, 2014-07-16 07:53:34]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[commit-bot: I haz the power, 2014-07-16 08:15:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-16 08:15:53]

Try jobs failed on following builders:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[tapted, 2014-07-16 13:03:45]

The CQ bit was checked by tapted@chromium.org

[commit-bot: I haz the power, 2014-07-16 13:06:10]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tapted@chromium.org/390183007/100001

[commit-bot: I haz the power, 2014-07-16 21:04:24]

Change committed as 283500