Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1036)

Unified Diff: chrome/browser/translate/chrome_translate_client.cc

Issue 390183007: MacViews: Move TranslateClient's InfoBar stub for toolkit-views to a static function in c/b/ui (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: just #ifdef+mac Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/translate/chrome_translate_client.cc
diff --git a/chrome/browser/translate/chrome_translate_client.cc b/chrome/browser/translate/chrome_translate_client.cc
index 7d3459c02fe388db68202f138fa8176ad123d0e5..56bdbf4034ce062bb387a602f13d3abb3aaac157 100644
--- a/chrome/browser/translate/chrome_translate_client.cc
+++ b/chrome/browser/translate/chrome_translate_client.cc
@@ -242,8 +242,9 @@ int ChromeTranslateClient::GetInfobarIconID() const {
}
// ChromeTranslateClient::CreateInfoBar() is implemented in platform-specific
-// files, except the TOOLKIT_VIEWS implementation, which has been removed.
-#if defined(TOOLKIT_VIEWS)
+// files, except the TOOLKIT_VIEWS implementation, which has been removed. Note
+// for Mac, Cocoa is still providing the infobar in a toolkit-views build.
+#if defined(TOOLKIT_VIEWS) && !defined(OS_MACOSX)
scoped_ptr<infobars::InfoBar> ChromeTranslateClient::CreateInfoBar(
scoped_ptr<TranslateInfoBarDelegate> delegate) const {
return scoped_ptr<infobars::InfoBar>();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698