ui: Add a minor unittest to check to work correctly with a empty clip in Blit.ScrollCanvas

ui: Add a minor unittest to check to work correctly with a empty clip in Blit.ScrollCanvas

BUG=none

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284039

[hyunki, 2014-07-14 16:02:58]

I think that simple sanity test for empty clip would be required.
Please take a look. Thanks. :)

[brettw, 2014-07-14 19:38:06]

Please pick one appropriate reviewer. Removing myself.

[hyunki, 2014-07-14 23:16:03]

On 2014/07/14 19:38:06, brettw wrote:
> Please pick one appropriate reviewer. Removing myself.

I've updated the reviewers. PTAL. Thanks.

[oshima, 2014-07-16 15:59:07]

I don't think you need my review. I'm not either familiar with this, nor an
OWNER.

[hyunki, 2014-07-16 16:05:05]

On 2014/07/16 15:59:07, oshima wrote:
> I don't think you need my review. I'm not either familiar with this, nor an
> OWNER.

Oh, sorry. I'll remove. Thanks for the comment.

[hyunki, 2014-07-16 18:40:14]

Ping. PTAL. Thank you.

[hyunki, 2014-07-17 15:32:51]

danakj@: another gentle ping. thank you!

[danakj, 2014-07-17 15:38:50]

I'm not familiar with this code, and not sure this is the correct behaviour.

sky has reviewed this file in the past.

[hyunki, 2014-07-17 15:40:39]

I get it. Thanks.

[hyunki, 2014-07-17 15:50:11]

sky@, gentle ping. thank you!

[sky, 2014-07-17 16:25:38]

I'm honestly not a good reviewer here too. I'll happily rubber stamp if you get
whoever wrote the blit code to review.

[hyunki, 2014-07-17 16:35:57]

hello brettw@,
could you please take a look for this test addition?
thank you!

[hyunki, 2014-07-17 16:37:44]

oops.. sorry, my mistake.
I'll find appropriate reviewer.

[hyunki, 2014-07-17 16:45:15]

Hello, junov@, sugoi@,
could you please take a look for test addition for empty clip?
thank you!

[Justin Novosad, 2014-07-17 17:16:40]

On 2014/07/17 16:45:15, hyunki wrote:
> Hello, junov@, sugoi@,
> could you please take a look for test addition for empty clip?
> thank you!

I am not an OWNER in this area, neither is sugoi

danakj@: You want to approve this?

[danakj, 2014-07-17 17:23:43]

On Thu, Jul 17, 2014 at 1:16 PM, <junov@chromium.org> wrote:

> On 2014/07/17 16:45:15, hyunki wrote:
>
>> Hello, junov@, sugoi@,
>> could you please take a look for test addition for empty clip?
>> thank you!
>>
>
> I am not an OWNER in this area, neither is sugoi
>
> danakj@: You want to approve this?
>

Been there, not done that. We need someone who actually understands this
code to decide if this change is right.

+brettw who added this code in http://codereview.chromium.org/2967008. Can
you comment on correctness?

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[brettw, 2014-07-17 20:17:59]

lgtm

[danakj, 2014-07-17 20:21:54]

rsLGTM

[hyunki, 2014-07-18 00:03:07]

Thanks for the review.

[hyunki, 2014-07-18 00:03:15]

The CQ bit was checked by hyunki.baik@samsung.com

[commit-bot: I haz the power, 2014-07-18 00:07:18]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/hyunki.baik@samsung.com/390083002/1

[commit-bot: I haz the power, 2014-07-18 09:13:05]

Change committed as 284039