Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 390083002: ui: Add a minor unittest to check to work correctly with a empty clip in Blit.ScrollCanvas (Closed)

Created:
6 years, 5 months ago by hyunki
Modified:
6 years, 5 months ago
CC:
chromium-reviews, oshima, danakj
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

ui: Add a minor unittest to check to work correctly with a empty clip in Blit.ScrollCanvas BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284039

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M ui/gfx/blit_unittest.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (0 generated)
hyunki
I think that simple sanity test for empty clip would be required. Please take a ...
6 years, 5 months ago (2014-07-14 16:02:58 UTC) #1
brettw
Please pick one appropriate reviewer. Removing myself.
6 years, 5 months ago (2014-07-14 19:38:06 UTC) #2
hyunki
On 2014/07/14 19:38:06, brettw wrote: > Please pick one appropriate reviewer. Removing myself. I've updated ...
6 years, 5 months ago (2014-07-14 23:16:03 UTC) #3
oshima
I don't think you need my review. I'm not either familiar with this, nor an ...
6 years, 5 months ago (2014-07-16 15:59:07 UTC) #4
hyunki
On 2014/07/16 15:59:07, oshima wrote: > I don't think you need my review. I'm not ...
6 years, 5 months ago (2014-07-16 16:05:05 UTC) #5
hyunki
Ping. PTAL. Thank you.
6 years, 5 months ago (2014-07-16 18:40:14 UTC) #6
hyunki
danakj@: another gentle ping. thank you!
6 years, 5 months ago (2014-07-17 15:32:51 UTC) #7
danakj
I'm not familiar with this code, and not sure this is the correct behaviour. sky ...
6 years, 5 months ago (2014-07-17 15:38:50 UTC) #8
hyunki
I get it. Thanks.
6 years, 5 months ago (2014-07-17 15:40:39 UTC) #9
hyunki
sky@, gentle ping. thank you!
6 years, 5 months ago (2014-07-17 15:50:11 UTC) #10
sky
I'm honestly not a good reviewer here too. I'll happily rubber stamp if you get ...
6 years, 5 months ago (2014-07-17 16:25:38 UTC) #11
hyunki
hello brettw@, could you please take a look for this test addition? thank you!
6 years, 5 months ago (2014-07-17 16:35:57 UTC) #12
hyunki
oops.. sorry, my mistake. I'll find appropriate reviewer.
6 years, 5 months ago (2014-07-17 16:37:44 UTC) #13
hyunki
Hello, junov@, sugoi@, could you please take a look for test addition for empty clip? ...
6 years, 5 months ago (2014-07-17 16:45:15 UTC) #14
Justin Novosad
On 2014/07/17 16:45:15, hyunki wrote: > Hello, junov@, sugoi@, > could you please take a ...
6 years, 5 months ago (2014-07-17 17:16:40 UTC) #15
danakj
On Thu, Jul 17, 2014 at 1:16 PM, <junov@chromium.org> wrote: > On 2014/07/17 16:45:15, hyunki ...
6 years, 5 months ago (2014-07-17 17:23:43 UTC) #16
brettw
lgtm
6 years, 5 months ago (2014-07-17 20:17:59 UTC) #17
danakj
rsLGTM
6 years, 5 months ago (2014-07-17 20:21:54 UTC) #18
hyunki
Thanks for the review.
6 years, 5 months ago (2014-07-18 00:03:07 UTC) #19
hyunki
The CQ bit was checked by hyunki.baik@samsung.com
6 years, 5 months ago (2014-07-18 00:03:15 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hyunki.baik@samsung.com/390083002/1
6 years, 5 months ago (2014-07-18 00:07:18 UTC) #21
commit-bot: I haz the power
6 years, 5 months ago (2014-07-18 09:13:05 UTC) #22
Message was sent while issue was closed.
Change committed as 284039

Powered by Google App Engine
This is Rietveld 408576698