Issue 2967008: Add a function to scroll a platform canvas. This uses the platform scroll...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2967008: Add a function to scroll a platform canvas. This uses the platform scroll... (Closed)

Created:
10 years, 5 months ago by brettw

Modified:
9 years, 7 months ago

Reviewers:
piman

CC:
chromium-reviews, Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Add a function to scroll a platform canvas. This uses the platform scroll functions when available, and on Linux implements a simple manual scroll function since Cairo/Skia doesn't provide one. BUG=none TEST=included unit test Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52442

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Patch Set 3 : '' #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+251 lines, -8 lines)			Patch
M	gfx/blit.h	View		1 chunk	+7 lines, -0 lines	0 comments	Download
M	gfx/blit.cc	View	1 2	2 chunks	+107 lines, -5 lines	0 comments	Download
A	gfx/blit_unittest.cc	View		1 chunk	+132 lines, -0 lines	0 comments	Download
M	gfx/gfx.gyp	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	gfx/skbitmap_operations.h	View		3 chunks	+4 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

piman

10 years, 5 months ago (2010-07-14 18:27:38 UTC) #2

just 1 thing in the test but other than that LGTM. I'm no windows expert, so I
trust you on the windows code...

http://codereview.chromium.org/2967008/diff/5001/6003
File gfx/blit_unittest.cc (right):

http://codereview.chromium.org/2967008/diff/5001/6003#newcode76
gfx/blit_unittest.cc:76: gfx::Point(0, 0));
wanna test the result here ?

Expand Messages | Collapse Messages