Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 390033002: Remove last SK_SUPPORT_LEGACY_SHADER_LOCALMATRIX. (Closed)

Created:
6 years, 5 months ago by scroggo
Modified:
6 years, 5 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Remove last SK_SUPPORT_LEGACY_SHADER_LOCALMATRIX. Should have been included in https://codereview.chromium.org/379323002 but it was overlooked. As of that CL, the flag does not do anything. BUG=skia:1976 Committed: https://skia.googlesource.com/skia/+/55d316eabad866f1e371fd0afad1ce97216241b9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M gyp/common_conditions.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
scroggo
6 years, 5 months ago (2014-07-14 14:08:46 UTC) #1
reed1
lgtm
6 years, 5 months ago (2014-07-14 14:20:37 UTC) #2
scroggo
The CQ bit was checked by scroggo@google.com
6 years, 5 months ago (2014-07-14 14:28:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/scroggo@google.com/390033002/1
6 years, 5 months ago (2014-07-14 14:29:53 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-14 14:58:40 UTC) #5
Message was sent while issue was closed.
Change committed as 55d316eabad866f1e371fd0afad1ce97216241b9

Powered by Google App Engine
This is Rietveld 408576698