Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 390023002: Make SkPictureShader and SkPictureImageFilter use const SkPictures (Closed)

Created:
6 years, 5 months ago by robertphillips
Modified:
6 years, 5 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Make SkPictureShader and SkPictureImageFilter use const SkPictures TBR=reed@google.com Committed: https://skia.googlesource.com/skia/+/e8464994bbcc797b47a5ee24aa513530d2bade3b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -14 lines) Patch
M include/effects/SkPictureImageFilter.h View 3 chunks +6 lines, -6 lines 0 comments Download
M src/core/SkPictureShader.h View 2 chunks +4 lines, -4 lines 0 comments Download
M src/core/SkPictureShader.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/effects/SkPictureImageFilter.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
robertphillips
6 years, 5 months ago (2014-07-14 11:51:49 UTC) #1
mtklein
lgtm
6 years, 5 months ago (2014-07-14 13:03:04 UTC) #2
robertphillips
The CQ bit was checked by robertphillips@google.com
6 years, 5 months ago (2014-07-14 13:51:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/robertphillips@google.com/390023002/1
6 years, 5 months ago (2014-07-14 13:51:33 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-14 13:51:36 UTC) #5
commit-bot: I haz the power
Presubmit check for 390023002-1 failed and returned exit status 1. Running presubmit commit checks ...
6 years, 5 months ago (2014-07-14 13:51:36 UTC) #6
reed1
lgtm
6 years, 5 months ago (2014-07-14 13:51:48 UTC) #7
reed1
The CQ bit was checked by reed@google.com
6 years, 5 months ago (2014-07-14 13:51:56 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/robertphillips@google.com/390023002/1
6 years, 5 months ago (2014-07-14 13:52:04 UTC) #9
commit-bot: I haz the power
6 years, 5 months ago (2014-07-14 14:53:31 UTC) #10
Message was sent while issue was closed.
Change committed as e8464994bbcc797b47a5ee24aa513530d2bade3b

Powered by Google App Engine
This is Rietveld 408576698