Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 389973004: cc: Give TilingData back a Size instead of a Rect. (Closed)

Created:
6 years, 5 months ago by danakj
Modified:
6 years, 5 months ago
Reviewers:
ernstm
CC:
chromium-reviews, cc-bugs_chromium.org, enne (OOO), piman, reveman
Project:
chromium
Visibility:
Public.

Description

cc: Give TilingData back a Size instead of a Rect. This is a semi-revert of https://codereview.chromium.org/235753002/. Since it seems that we are not using the ability of TilingData to have a non-zero origin, having a Rect is not needed and less clear what is going on. R=ernstm@chromium.org BUG=362668, 386998 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283374

Patch Set 1 : tilingsize: #

Patch Set 2 : tilingsize: perfests #

Total comments: 2

Patch Set 3 : tilingsize: comments #

Patch Set 4 : tilingsize: comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1129 lines, -2762 lines) Patch
M cc/base/tiling_data.h View 3 chunks +6 lines, -6 lines 0 comments Download
M cc/base/tiling_data.cc View 23 chunks +54 lines, -63 lines 0 comments Download
M cc/base/tiling_data_unittest.cc View 1 2 39 chunks +832 lines, -2462 lines 0 comments Download
M cc/layers/picture_layer.cc View 4 chunks +5 lines, -7 lines 0 comments Download
M cc/layers/picture_layer_impl_unittest.cc View 4 chunks +12 lines, -4 lines 0 comments Download
M cc/layers/picture_layer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/tiled_layer.cc View 1 chunk +7 lines, -8 lines 0 comments Download
M cc/layers/tiled_layer_impl_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/resources/layer_tiling_data.h View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/resources/layer_tiling_data.cc View 3 chunks +6 lines, -5 lines 0 comments Download
M cc/resources/picture_layer_tiling.h View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/resources/picture_layer_tiling.cc View 10 chunks +15 lines, -14 lines 0 comments Download
M cc/resources/picture_layer_tiling_perftest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/resources/picture_layer_tiling_set.cc View 1 chunk +5 lines, -1 line 0 comments Download
M cc/resources/picture_layer_tiling_set_unittest.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M cc/resources/picture_layer_tiling_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/resources/picture_pile.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/resources/picture_pile.cc View 4 chunks +69 lines, -76 lines 0 comments Download
M cc/resources/picture_pile_base.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/resources/picture_pile_base.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/resources/picture_pile_impl.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M cc/resources/picture_pile_unittest.cc View 43 chunks +89 lines, -88 lines 0 comments Download
M cc/test/fake_picture_layer_impl.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M cc/test/fake_picture_pile_impl.cc View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
danakj
6 years, 5 months ago (2014-07-14 19:10:32 UTC) #1
ernstm
Thanks! LGTM https://codereview.chromium.org/389973004/diff/40001/cc/base/tiling_data_unittest.cc File cc/base/tiling_data_unittest.cc (right): https://codereview.chromium.org/389973004/diff/40001/cc/base/tiling_data_unittest.cc#newcode1155 cc/base/tiling_data_unittest.cc:1155: // The following Coordinates are relative to ...
6 years, 5 months ago (2014-07-15 11:18:13 UTC) #2
danakj
Thanks! https://codereview.chromium.org/389973004/diff/40001/cc/base/tiling_data_unittest.cc File cc/base/tiling_data_unittest.cc (right): https://codereview.chromium.org/389973004/diff/40001/cc/base/tiling_data_unittest.cc#newcode1155 cc/base/tiling_data_unittest.cc:1155: // The following Coordinates are relative to the ...
6 years, 5 months ago (2014-07-15 15:01:00 UTC) #3
danakj
The CQ bit was checked by danakj@chromium.org
6 years, 5 months ago (2014-07-15 15:01:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/389973004/80001
6 years, 5 months ago (2014-07-15 15:03:24 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-15 21:06:46 UTC) #6
danakj
The CQ bit was unchecked by danakj@chromium.org
6 years, 5 months ago (2014-07-15 21:28:17 UTC) #7
danakj
The CQ bit was checked by danakj@chromium.org
6 years, 5 months ago (2014-07-15 21:28:18 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/389973004/80001
6 years, 5 months ago (2014-07-15 21:29:27 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 5 months ago (2014-07-16 01:14:02 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-16 01:40:03 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/170891)
6 years, 5 months ago (2014-07-16 01:40:04 UTC) #12
danakj
The CQ bit was checked by danakj@chromium.org
6 years, 5 months ago (2014-07-16 06:03:43 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/389973004/80001
6 years, 5 months ago (2014-07-16 06:07:40 UTC) #14
commit-bot: I haz the power
6 years, 5 months ago (2014-07-16 06:10:32 UTC) #15
Message was sent while issue was closed.
Change committed as 283374

Powered by Google App Engine
This is Rietveld 408576698