Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 389973002: [fsp] Add support for moving files within a provided file system. (Closed)

Created:
6 years, 5 months ago by mtomasz
Modified:
6 years, 5 months ago
Reviewers:
benwells, hirono, kinaba
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, tzik, nhiroki, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, kinuko+fileapi, davemoore+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

[fsp] Add support for moving files within a provided file system. This CL adds support for moving files which are on the same provided file system. Note, that moving between file system instances will be done using FileStreamWriter. TEST=unit_tests, browser_tests: *FileSystemProvider*Move* BUG=391362 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285000

Patch Set 1 #

Total comments: 4

Patch Set 2 : Fixed. #

Total comments: 2

Patch Set 3 : Rebased. #

Patch Set 4 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+193 lines, -58 lines) Patch
M chrome/browser/chromeos/extensions/file_system_provider/file_system_provider_apitest.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/fake_provided_file_system.h View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/fake_provided_file_system.cc View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/fileapi/provider_async_file_util.cc View 2 chunks +36 lines, -1 line 0 comments Download
M chrome/browser/chromeos/file_system_provider/fileapi/provider_async_file_util_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/file_system_provider/operations/create_directory_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/file_system_provider/operations/delete_entry_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
A + chrome/browser/chromeos/file_system_provider/operations/move_entry.h View 3 chunks +7 lines, -7 lines 0 comments Download
A + chrome/browser/chromeos/file_system_provider/operations/move_entry.cc View 3 chunks +7 lines, -7 lines 0 comments Download
A + chrome/browser/chromeos/file_system_provider/operations/move_entry_unittest.cc View 1 4 chunks +23 lines, -23 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/provided_file_system.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/provided_file_system.cc View 2 chunks +17 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/provided_file_system_interface.h View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/request_manager.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/request_manager.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/common/extensions/api/file_system_provider.idl View 2 chunks +15 lines, -0 lines 0 comments Download
M chrome/renderer/resources/extensions/file_system_provider_custom_bindings.js View 1 chunk +4 lines, -0 lines 0 comments Download
A + chrome/test/data/extensions/api_test/file_system_provider/move_entry/manifest.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/extensions/api_test/file_system_provider/move_entry/test.js View 1 5 chunks +41 lines, -15 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
mtomasz
As before, this CL is almost the same as the CopyEntry one. @kinaba: PTAL at ...
6 years, 5 months ago (2014-07-14 09:25:23 UTC) #1
hirono
lgtm for *.js.
6 years, 5 months ago (2014-07-14 10:02:31 UTC) #2
kinaba
lgtm https://codereview.chromium.org/389973002/diff/1/chrome/browser/chromeos/file_system_provider/operations/move_entry_unittest.cc File chrome/browser/chromeos/file_system_provider/operations/move_entry_unittest.cc (right): https://codereview.chromium.org/389973002/diff/1/chrome/browser/chromeos/file_system_provider/operations/move_entry_unittest.cc#newcode12 chrome/browser/chromeos/file_system_provider/operations/move_entry_unittest.cc:12: #include "chrome/browser/chromeos/file_system_provider/operations/move_entry.h" You can move this line to ...
6 years, 5 months ago (2014-07-15 07:12:54 UTC) #3
mtomasz
https://codereview.chromium.org/389973002/diff/1/chrome/browser/chromeos/file_system_provider/operations/move_entry_unittest.cc File chrome/browser/chromeos/file_system_provider/operations/move_entry_unittest.cc (right): https://codereview.chromium.org/389973002/diff/1/chrome/browser/chromeos/file_system_provider/operations/move_entry_unittest.cc#newcode12 chrome/browser/chromeos/file_system_provider/operations/move_entry_unittest.cc:12: #include "chrome/browser/chromeos/file_system_provider/operations/move_entry.h" On 2014/07/15 07:12:54, kinaba wrote: > You ...
6 years, 5 months ago (2014-07-16 07:36:12 UTC) #4
benwells
https://codereview.chromium.org/389973002/diff/20001/chrome/common/extensions/api/file_system_provider.idl File chrome/common/extensions/api/file_system_provider.idl (right): https://codereview.chromium.org/389973002/diff/20001/chrome/common/extensions/api/file_system_provider.idl#newcode265 chrome/common/extensions/api/file_system_provider.idl:265: [maxListeners=1, nodoc] static void onCreateDirectoryRequested( Hmm ... why are ...
6 years, 5 months ago (2014-07-18 04:28:18 UTC) #5
mtomasz
https://codereview.chromium.org/389973002/diff/20001/chrome/common/extensions/api/file_system_provider.idl File chrome/common/extensions/api/file_system_provider.idl (right): https://codereview.chromium.org/389973002/diff/20001/chrome/common/extensions/api/file_system_provider.idl#newcode265 chrome/common/extensions/api/file_system_provider.idl:265: [maxListeners=1, nodoc] static void onCreateDirectoryRequested( On 2014/07/18 04:28:18, benwells ...
6 years, 5 months ago (2014-07-19 01:22:23 UTC) #6
benwells
lgtm
6 years, 5 months ago (2014-07-21 05:34:34 UTC) #7
mtomasz
The CQ bit was checked by mtomasz@chromium.org
6 years, 5 months ago (2014-07-23 14:09:09 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/389973002/60001
6 years, 5 months ago (2014-07-23 14:10:02 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 5 months ago (2014-07-23 16:34:31 UTC) #10
commit-bot: I haz the power
6 years, 5 months ago (2014-07-23 18:52:47 UTC) #11
Message was sent while issue was closed. 
Change committed as 285000

Powered by Google App Engine
This is Rietveld 408576698