[fsp] Add support for moving files within a provided file system.

chrome/browser/chromeos/file_system_provider/operations/move_entry_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#include "chrome/browser/chromeos/file_system_provider/operations/copy_entry.h"
-
 #include <string>
 #include <vector>
 
 #include "base/files/file.h"
 #include "base/files/file_path.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/scoped_vector.h"
+#include "chrome/browser/chromeos/file_system_provider/operations/move_entry.h"

[kinaba, 2014/07/15 07:12:54]

You can move this line to the top of the #includes.

[mtomasz, 2014/07/16 07:36:12]

Done.

 #include "chrome/browser/chromeos/file_system_provider/operations/test_util.h"
 #include "chrome/browser/chromeos/file_system_provider/provided_file_system_interface.h"
 #include "chrome/common/extensions/api/file_system_provider.h"
 #include "chrome/common/extensions/api/file_system_provider_internal.h"
 #include "extensions/browser/event_router.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "webkit/browser/fileapi/async_file_util.h"
 
 namespace chromeos {
 namespace file_system_provider {
 namespace operations {
 namespace {
 
 const char kExtensionId[] = "mbflcebpggnecokmikipoihdbecnjfoj";
 const char kFileSystemId[] = "testing-file-system";
 const int kRequestId = 2;
 const base::FilePath::CharType kSourcePath[] = "/bunny/and/bear/happy";
 const base::FilePath::CharType kTargetPath[] = "/kitty/and/puppy/happy";
 
 }  // namespace
 
-class FileSystemProviderOperationsCopyEntryTest : public testing::Test {
+class FileSystemProviderOperationsMoveEntryTest : public testing::Test {
  protected:
-  FileSystemProviderOperationsCopyEntryTest() {}
-  virtual ~FileSystemProviderOperationsCopyEntryTest() {}
+  FileSystemProviderOperationsMoveEntryTest() {}
+  virtual ~FileSystemProviderOperationsMoveEntryTest() {}
 
   virtual void SetUp() OVERRIDE {
     file_system_info_ =
         ProvidedFileSystemInfo(kExtensionId,
                                kFileSystemId,
                                "" /* file_system_name */,
                                true /* writable */,
                                base::FilePath() /* mount_path */);
   }
 
   ProvidedFileSystemInfo file_system_info_;
 };
 
-TEST_F(FileSystemProviderOperationsCopyEntryTest, Execute) {
+TEST_F(FileSystemProviderOperationsMoveEntryTest, Execute) {
   util::LoggingDispatchEventImpl dispatcher(true /* dispatch_reply */);
   util::StatusCallbackLog callback_log;
 
-  CopyEntry copy_entry(NULL,
+  MoveEntry move_entry(NULL,
                        file_system_info_,
                        base::FilePath::FromUTF8Unsafe(kSourcePath),
                        base::FilePath::FromUTF8Unsafe(kTargetPath),
                        base::Bind(&util::LogStatusCallback, &callback_log));
-  copy_entry.SetDispatchEventImplForTesting(
+  move_entry.SetDispatchEventImplForTesting(
       base::Bind(&util::LoggingDispatchEventImpl::OnDispatchEventImpl,
                  base::Unretained(&dispatcher)));
 
-  EXPECT_TRUE(copy_entry.Execute(kRequestId));
+  EXPECT_TRUE(move_entry.Execute(kRequestId));
 
   ASSERT_EQ(1u, dispatcher.events().size());
   extensions::Event* event = dispatcher.events()[0];
   EXPECT_EQ(
-      extensions::api::file_system_provider::OnCopyEntryRequested::kEventName,
+      extensions::api::file_system_provider::OnMoveEntryRequested::kEventName,
       event->event_name);
   base::ListValue* event_args = event->event_args.get();
   ASSERT_EQ(1u, event_args->GetSize());
 
   base::DictionaryValue* options = NULL;
   ASSERT_TRUE(event_args->GetDictionary(0, &options));
 
   std::string event_file_system_id;
   EXPECT_TRUE(options->GetString("fileSystemId", &event_file_system_id));
   EXPECT_EQ(kFileSystemId, event_file_system_id);
 
   int event_request_id = -1;
   EXPECT_TRUE(options->GetInteger("requestId", &event_request_id));
   EXPECT_EQ(kRequestId, event_request_id);
 
   std::string event_source_path;
   EXPECT_TRUE(options->GetString("sourcePath", &event_source_path));
   EXPECT_EQ(kSourcePath, event_source_path);
 
   std::string event_target_path;
   EXPECT_TRUE(options->GetString("targetPath", &event_target_path));
   EXPECT_EQ(kTargetPath, event_target_path);
 }
 
-TEST_F(FileSystemProviderOperationsCopyEntryTest, Execute_NoListener) {
+TEST_F(FileSystemProviderOperationsMoveEntryTest, Execute_NoListener) {
   util::LoggingDispatchEventImpl dispatcher(false /* dispatch_reply */);
   util::StatusCallbackLog callback_log;
 
-  CopyEntry copy_entry(NULL,
+  MoveEntry move_entry(NULL,
                        file_system_info_,
                        base::FilePath::FromUTF8Unsafe(kSourcePath),
                        base::FilePath::FromUTF8Unsafe(kTargetPath),
                        base::Bind(&util::LogStatusCallback, &callback_log));
-  copy_entry.SetDispatchEventImplForTesting(
+  move_entry.SetDispatchEventImplForTesting(
       base::Bind(&util::LoggingDispatchEventImpl::OnDispatchEventImpl,
                  base::Unretained(&dispatcher)));
 
-  EXPECT_FALSE(copy_entry.Execute(kRequestId));
+  EXPECT_FALSE(move_entry.Execute(kRequestId));
 }
 
-TEST_F(FileSystemProviderOperationsCopyEntryTest, OnSuccess) {
+TEST_F(FileSystemProviderOperationsMoveEntryTest, OnSuccess) {
   util::LoggingDispatchEventImpl dispatcher(true /* dispatch_reply */);
   util::StatusCallbackLog callback_log;
 
-  CopyEntry copy_entry(NULL,
+  MoveEntry move_entry(NULL,
                        file_system_info_,
                        base::FilePath::FromUTF8Unsafe(kSourcePath),
                        base::FilePath::FromUTF8Unsafe(kTargetPath),
                        base::Bind(&util::LogStatusCallback, &callback_log));
-  copy_entry.SetDispatchEventImplForTesting(
+  move_entry.SetDispatchEventImplForTesting(
       base::Bind(&util::LoggingDispatchEventImpl::OnDispatchEventImpl,
                  base::Unretained(&dispatcher)));
 
-  EXPECT_TRUE(copy_entry.Execute(kRequestId));
+  EXPECT_TRUE(move_entry.Execute(kRequestId));
 
-  copy_entry.OnSuccess(kRequestId,
+  move_entry.OnSuccess(kRequestId,
                        scoped_ptr<RequestValue>(new RequestValue()),
                        false /* has_more */);
   ASSERT_EQ(1u, callback_log.size());
   EXPECT_EQ(base::File::FILE_OK, callback_log[0]);
 }
 
-TEST_F(FileSystemProviderOperationsCopyEntryTest, OnError) {
+TEST_F(FileSystemProviderOperationsMoveEntryTest, OnError) {
   util::LoggingDispatchEventImpl dispatcher(true /* dispatch_reply */);
   util::StatusCallbackLog callback_log;
 
-  CopyEntry copy_entry(NULL,
+  MoveEntry move_entry(NULL,
                        file_system_info_,
                        base::FilePath::FromUTF8Unsafe(kSourcePath),
                        base::FilePath::FromUTF8Unsafe(kTargetPath),
                        base::Bind(&util::LogStatusCallback, &callback_log));
-  copy_entry.SetDispatchEventImplForTesting(
+  move_entry.SetDispatchEventImplForTesting(
       base::Bind(&util::LoggingDispatchEventImpl::OnDispatchEventImpl,
                  base::Unretained(&dispatcher)));
 
-  EXPECT_TRUE(copy_entry.Execute(kRequestId));
+  EXPECT_TRUE(move_entry.Execute(kRequestId));
 
-  copy_entry.OnError(kRequestId,
+  move_entry.OnError(kRequestId,
                      scoped_ptr<RequestValue>(new RequestValue()),
                      base::File::FILE_ERROR_TOO_MANY_OPENED);
   ASSERT_EQ(1u, callback_log.size());
   EXPECT_EQ(base::File::FILE_ERROR_TOO_MANY_OPENED, callback_log[0]);
 }
 
 }  // namespace operations
 }  // namespace file_system_provider
 }  // namespace chromeos