[fsp] Add support for creating files.

[fsp] Add support for creating files.

This patch adds support for creating files via AsyncFileUtil::EnsureFileExists.
Note, that creating files from NaCL is not supported yet.

TEST=unit_tests, browser_tests: *FileSystemProvider*EnsureFile*,
     *FileSystemProvider*CreateFile*
BUG=391362
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284873

[mtomasz, 2014-07-14 02:33:22]

As before, the code is almost identical to other operations. The main difference
is that in provider_async_file_util.cc we are converting base::FILE_ERROR_EXISTS
to base::FILE_OK since, we are using CreateFile to implement EnsureFileExists.

@kinaba: PTAL at C++.
@benwells: PTAL at IDL.
@hirono: PTAL at JS.

Thanks.

[hirono, 2014-07-14 05:08:35]

https://codereview.chromium.org/389893002/diff/1/chrome/test/data/extensions/...
File
chrome/test/data/extensions/api_test/file_system_provider/create_file/test.js
(right):

https://codereview.chromium.org/389893002/diff/1/chrome/test/data/extensions/...
chrome/test/data/extensions/api_test/file_system_provider/create_file/test.js:66:
test_util.defaultMetadata['/' + TESTING_FILE.name] = TESTING_FILE;
Is it needed?

[kinaba, 2014-07-14 05:14:46]

lgtm

[mtomasz, 2014-07-14 06:05:37]

https://codereview.chromium.org/389893002/diff/1/chrome/test/data/extensions/...
File
chrome/test/data/extensions/api_test/file_system_provider/create_file/test.js
(right):

https://codereview.chromium.org/389893002/diff/1/chrome/test/data/extensions/...
chrome/test/data/extensions/api_test/file_system_provider/create_file/test.js:66:
test_util.defaultMetadata['/' + TESTING_FILE.name] = TESTING_FILE;
On 2014/07/14 05:08:35, hirono wrote:
> Is it needed?

It is used in #96, in order to check if creating a file which already exists
fails.

[hirono, 2014-07-14 06:07:15]

On 2014/07/14 06:05:37, mtomasz wrote:
>
https://codereview.chromium.org/389893002/diff/1/chrome/test/data/extensions/...
> File
> chrome/test/data/extensions/api_test/file_system_provider/create_file/test.js
> (right):
> 
>
https://codereview.chromium.org/389893002/diff/1/chrome/test/data/extensions/...
>
chrome/test/data/extensions/api_test/file_system_provider/create_file/test.js:66:
> test_util.defaultMetadata['/' + TESTING_FILE.name] = TESTING_FILE;
> On 2014/07/14 05:08:35, hirono wrote:
> > Is it needed?
> 
> It is used in #96, in order to check if creating a file which already exists
> fails.

Got it. Thanks! lgtm

[benwells, 2014-07-18 04:23:59]

idl / custom bindings lgtm

[mtomasz, 2014-07-23 00:16:36]

The CQ bit was checked by mtomasz@chromium.org

[commit-bot: I haz the power, 2014-07-23 00:20:23]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mtomasz@chromium.org/389893002/20001

[commit-bot: I haz the power, 2014-07-23 04:27:30]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

[commit-bot: I haz the power, 2014-07-23 05:49:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-23 05:49:34]

Try jobs failed on following builders:
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

[mtomasz, 2014-07-23 06:30:34]

The CQ bit was checked by mtomasz@chromium.org

[commit-bot: I haz the power, 2014-07-23 06:32:07]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mtomasz@chromium.org/389893002/20001

[commit-bot: I haz the power, 2014-07-23 06:55:31]

Change committed as 284873