Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Unified Diff: chrome/browser/chromeos/file_system_provider/operations/create_file_unittest.cc

Issue 389893002: [fsp] Add support for creating files. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebased. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/file_system_provider/operations/create_file_unittest.cc
diff --git a/chrome/browser/chromeos/file_system_provider/operations/close_file_unittest.cc b/chrome/browser/chromeos/file_system_provider/operations/create_file_unittest.cc
similarity index 56%
copy from chrome/browser/chromeos/file_system_provider/operations/close_file_unittest.cc
copy to chrome/browser/chromeos/file_system_provider/operations/create_file_unittest.cc
index c4af6106088a6c9412605881343c303d5d25d7d2..1dbce12445c432556e2944630a9adf849a067cf9 100644
--- a/chrome/browser/chromeos/file_system_provider/operations/close_file_unittest.cc
+++ b/chrome/browser/chromeos/file_system_provider/operations/create_file_unittest.cc
@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "chrome/browser/chromeos/file_system_provider/operations/close_file.h"
+#include "chrome/browser/chromeos/file_system_provider/operations/create_file.h"
#include <string>
#include <vector>
@@ -10,6 +10,7 @@
#include "base/files/file.h"
#include "base/files/file_path.h"
#include "base/memory/scoped_ptr.h"
+#include "base/memory/scoped_vector.h"
#include "chrome/browser/chromeos/file_system_provider/operations/test_util.h"
#include "chrome/browser/chromeos/file_system_provider/provided_file_system_interface.h"
#include "chrome/common/extensions/api/file_system_provider.h"
@@ -26,45 +27,45 @@ namespace {
const char kExtensionId[] = "mbflcebpggnecokmikipoihdbecnjfoj";
const char kFileSystemId[] = "testing-file-system";
const int kRequestId = 2;
-const int kOpenRequestId = 3;
+const base::FilePath::CharType kFilePath[] = "/kitty/and/puppy/happy";
} // namespace
-class FileSystemProviderOperationsCloseFileTest : public testing::Test {
+class FileSystemProviderOperationsCreateFileTest : public testing::Test {
protected:
- FileSystemProviderOperationsCloseFileTest() {}
- virtual ~FileSystemProviderOperationsCloseFileTest() {}
+ FileSystemProviderOperationsCreateFileTest() {}
+ virtual ~FileSystemProviderOperationsCreateFileTest() {}
virtual void SetUp() OVERRIDE {
file_system_info_ =
ProvidedFileSystemInfo(kExtensionId,
kFileSystemId,
- "" /* display_name */,
- false /* writable */,
+ "" /* file_system_name */,
+ true /* writable */,
base::FilePath() /* mount_path */);
}
ProvidedFileSystemInfo file_system_info_;
};
-TEST_F(FileSystemProviderOperationsCloseFileTest, Execute) {
+TEST_F(FileSystemProviderOperationsCreateFileTest, Execute) {
util::LoggingDispatchEventImpl dispatcher(true /* dispatch_reply */);
util::StatusCallbackLog callback_log;
- CloseFile close_file(NULL,
- file_system_info_,
- kOpenRequestId,
- base::Bind(&util::LogStatusCallback, &callback_log));
- close_file.SetDispatchEventImplForTesting(
+ CreateFile create_file(NULL,
+ file_system_info_,
+ base::FilePath::FromUTF8Unsafe(kFilePath),
+ base::Bind(&util::LogStatusCallback, &callback_log));
+ create_file.SetDispatchEventImplForTesting(
base::Bind(&util::LoggingDispatchEventImpl::OnDispatchEventImpl,
base::Unretained(&dispatcher)));
- EXPECT_TRUE(close_file.Execute(kRequestId));
+ EXPECT_TRUE(create_file.Execute(kRequestId));
ASSERT_EQ(1u, dispatcher.events().size());
extensions::Event* event = dispatcher.events()[0];
EXPECT_EQ(
- extensions::api::file_system_provider::OnCloseFileRequested::kEventName,
+ extensions::api::file_system_provider::OnCreateFileRequested::kEventName,
event->event_name);
base::ListValue* event_args = event->event_args.get();
ASSERT_EQ(1u, event_args->GetSize());
@@ -80,64 +81,64 @@ TEST_F(FileSystemProviderOperationsCloseFileTest, Execute) {
EXPECT_TRUE(options->GetInteger("requestId", &event_request_id));
EXPECT_EQ(kRequestId, event_request_id);
- int event_open_request_id = -1;
- EXPECT_TRUE(options->GetInteger("openRequestId", &event_open_request_id));
- EXPECT_EQ(kOpenRequestId, event_open_request_id);
+ std::string event_file_path;
+ EXPECT_TRUE(options->GetString("filePath", &event_file_path));
+ EXPECT_EQ(kFilePath, event_file_path);
}
-TEST_F(FileSystemProviderOperationsCloseFileTest, Execute_NoListener) {
+TEST_F(FileSystemProviderOperationsCreateFileTest, Execute_NoListener) {
util::LoggingDispatchEventImpl dispatcher(false /* dispatch_reply */);
util::StatusCallbackLog callback_log;
- CloseFile close_file(NULL,
- file_system_info_,
- kOpenRequestId,
- base::Bind(&util::LogStatusCallback, &callback_log));
- close_file.SetDispatchEventImplForTesting(
+ CreateFile create_file(NULL,
+ file_system_info_,
+ base::FilePath::FromUTF8Unsafe(kFilePath),
+ base::Bind(&util::LogStatusCallback, &callback_log));
+ create_file.SetDispatchEventImplForTesting(
base::Bind(&util::LoggingDispatchEventImpl::OnDispatchEventImpl,
base::Unretained(&dispatcher)));
- EXPECT_FALSE(close_file.Execute(kRequestId));
+ EXPECT_FALSE(create_file.Execute(kRequestId));
}
-TEST_F(FileSystemProviderOperationsCloseFileTest, OnSuccess) {
+TEST_F(FileSystemProviderOperationsCreateFileTest, OnSuccess) {
util::LoggingDispatchEventImpl dispatcher(true /* dispatch_reply */);
util::StatusCallbackLog callback_log;
- CloseFile close_file(NULL,
- file_system_info_,
- kOpenRequestId,
- base::Bind(&util::LogStatusCallback, &callback_log));
- close_file.SetDispatchEventImplForTesting(
+ CreateFile create_file(NULL,
+ file_system_info_,
+ base::FilePath::FromUTF8Unsafe(kFilePath),
+ base::Bind(&util::LogStatusCallback, &callback_log));
+ create_file.SetDispatchEventImplForTesting(
base::Bind(&util::LoggingDispatchEventImpl::OnDispatchEventImpl,
base::Unretained(&dispatcher)));
- EXPECT_TRUE(close_file.Execute(kRequestId));
+ EXPECT_TRUE(create_file.Execute(kRequestId));
- close_file.OnSuccess(kRequestId,
- scoped_ptr<RequestValue>(new RequestValue()),
- false /* has_more */);
+ create_file.OnSuccess(kRequestId,
+ scoped_ptr<RequestValue>(new RequestValue()),
+ false /* has_more */);
ASSERT_EQ(1u, callback_log.size());
EXPECT_EQ(base::File::FILE_OK, callback_log[0]);
}
-TEST_F(FileSystemProviderOperationsCloseFileTest, OnError) {
+TEST_F(FileSystemProviderOperationsCreateFileTest, OnError) {
util::LoggingDispatchEventImpl dispatcher(true /* dispatch_reply */);
util::StatusCallbackLog callback_log;
- CloseFile close_file(NULL,
- file_system_info_,
- kOpenRequestId,
- base::Bind(&util::LogStatusCallback, &callback_log));
- close_file.SetDispatchEventImplForTesting(
+ CreateFile create_file(NULL,
+ file_system_info_,
+ base::FilePath::FromUTF8Unsafe(kFilePath),
+ base::Bind(&util::LogStatusCallback, &callback_log));
+ create_file.SetDispatchEventImplForTesting(
base::Bind(&util::LoggingDispatchEventImpl::OnDispatchEventImpl,
base::Unretained(&dispatcher)));
- EXPECT_TRUE(close_file.Execute(kRequestId));
+ EXPECT_TRUE(create_file.Execute(kRequestId));
- close_file.OnError(kRequestId,
- scoped_ptr<RequestValue>(new RequestValue()),
- base::File::FILE_ERROR_TOO_MANY_OPENED);
+ create_file.OnError(kRequestId,
+ scoped_ptr<RequestValue>(new RequestValue()),
+ base::File::FILE_ERROR_TOO_MANY_OPENED);
ASSERT_EQ(1u, callback_log.size());
EXPECT_EQ(base::File::FILE_ERROR_TOO_MANY_OPENED, callback_log[0]);
}

Powered by Google App Engine
This is Rietveld 408576698