gyp/flags.gyp - Issue 389653004: share dm and command flags

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gyp/flags.gyp

Issue 389653004: share dm and command flags (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: gyp/flags.gyp

diff --git a/gyp/flags.gyp b/gyp/flags.gyp

index 874a4b20c1dd5aece375d5f5ce6c3f89ed856f9f..981fa1d6f47401fd45b878c6ed3360611a77c4c4 100644

--- a/gyp/flags.gyp

+++ b/gyp/flags.gyp

@@ -6,6 +6,8 @@

'target_name': 'flags',

'type': 'static_library',

'sources': [

+ '../tools/flags/SkCommonFlags.cpp',

scroggo 2014/07/11 21:12:14 I'm not sure these belong in the same library. Wha

caryclark 2014/07/14 12:24:46 My thought is the target can #include "SkCommandLi

+ '../tools/flags/SkCommonFlags.h',

'../tools/flags/SkCommandLineFlags.cpp',

'../tools/flags/SkCommandLineFlags.h',