gyp/flags.gyp - Issue 389653004: share dm and command flags

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: gyp/flags.gyp

Issue 389653004: share dm and command flags (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 # GYP file to build flag parser	1 # GYP file to build flag parser

2 #	2 #

3 {	3 {

4 'targets': [	4 'targets': [

5 {	5 {

6 'target_name': 'flags',	6 'target_name': 'flags',

7 'type': 'static_library',	7 'type': 'static_library',

8 'sources': [	8 'sources': [

	9 '../tools/flags/SkCommonFlags.cpp',
	scroggo 2014/07/11 21:12:14 I'm not sure these belong in the same library. Wha I'm not sure these belong in the same library. What if a target wants to use SkCommandLineFlags but doesn't want the common ones? Or it wants to define them differently? (If you push back I'm not completely opposed; but I do lean towards separating it out.) caryclark 2014/07/14 12:24:46 My thought is the target can #include "SkCommandLi My thought is the target can #include "SkCommandLineFlags.h" if they don't want the common ones. If they want to define them differently, then, Houston, we have a problem. The common flags should only be ones we feel comfortable with across all tools.
	10 '../tools/flags/SkCommonFlags.h',

9 '../tools/flags/SkCommandLineFlags.cpp',	11 '../tools/flags/SkCommandLineFlags.cpp',

10 '../tools/flags/SkCommandLineFlags.h',	12 '../tools/flags/SkCommandLineFlags.h',

11 ],	13 ],

12 'dependencies': [	14 'dependencies': [

13 'skia_lib.gyp:skia_lib',	15 'skia_lib.gyp:skia_lib',

14 ],	16 ],

15 'direct_dependent_settings': {	17 'direct_dependent_settings': {

16 'include_dirs': [	18 'include_dirs': [

17 '../tools/flags',	19 '../tools/flags',

18 ],	20 ],

19 }	21 }

20 },	22 },

21 ],	23 ],

22 }	24 }

OLD	NEW