Issue 389563002: DevTools: make paint profiler target-aware

Issue 389563002: DevTools: make paint profiler target-aware (Closed)

Created:
6 years, 5 months ago by caseq

Modified:
6 years, 5 months ago

Reviewers:
vsevik, apavlov, sergeyv, yurys

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

DevTools: make paint profiler target-aware - introduce WeakReference, that is cleared when its host is disposed; - pass target around as a WeakReference, so that when the target is disposed, the caller won't be able to use stale object; - replace direct calls to LayerAgent's paint profiler methods with calls to PaintProfilerSnapshot; Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178040

Patch Set 1 #

Total comments: 1

Patch Set 2 : use WeakReference to Target in places thay may outlive tatget #

Total comments: 1

Patch Set 3 : fixed a test and a stray line #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+193 lines, -114 lines)			Patch
M	LayoutTests/inspector/timeline/timeline-layer-tree-snapshot.html	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/virtual/implsidepainting/inspector/timeline/tracing/paint-command-log-nodes.html	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/devtools/front_end/common/utilities.js	View	1	1 chunk	+26 lines, -0 lines	0 comments	Download
M	Source/devtools/front_end/sdk/LayerTreeModel.js	View	1	16 chunks	+45 lines, -34 lines	0 comments	Download
M	Source/devtools/front_end/sdk/PaintProfiler.js	View	1	6 chunks	+29 lines, -9 lines	0 comments	Download
M	Source/devtools/front_end/sdk/Target.js	View	1 2	3 chunks	+11 lines, -0 lines	0 comments	Download
M	Source/devtools/front_end/timeline/TimelineFrameModel.js	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/devtools/front_end/timeline/TimelineLayersView.js	View	1	3 chunks	+35 lines, -30 lines	0 comments	Download
M	Source/devtools/front_end/timeline/TimelinePaintProfilerView.js	View	1	2 chunks	+26 lines, -14 lines	0 comments	Download
M	Source/devtools/front_end/timeline/TimelinePanel.js	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/devtools/front_end/timeline/TimelineTracingView.js	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
M	Source/devtools/front_end/timeline/TracingTimelineUIUtils.js	View	1	2 chunks	+13 lines, -19 lines	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

sergeyv

https://codereview.chromium.org/389563002/diff/1/Source/devtools/front_end/sdk/PaintProfiler.js File Source/devtools/front_end/sdk/PaintProfiler.js (right): https://codereview.chromium.org/389563002/diff/1/Source/devtools/front_end/sdk/PaintProfiler.js#newcode37 Source/devtools/front_end/sdk/PaintProfiler.js:37: WebInspector.PaintProfilerSnapshot = function(target, snapshotId) As we spoke offline, this ...

6 years, 5 months ago (2014-07-11 11:29:00 UTC) #2

caseq

PTAL As discussed offline, introduced WeakRefernece wrapper for target and switched to use it where ...

6 years, 5 months ago (2014-07-11 16:23:13 UTC) #3

apavlov

https://codereview.chromium.org/389563002/diff/20001/Source/devtools/front_end/sdk/Target.js File Source/devtools/front_end/sdk/Target.js (right): https://codereview.chromium.org/389563002/diff/20001/Source/devtools/front_end/sdk/Target.js#newcode204 Source/devtools/front_end/sdk/Target.js:204: stray blank line

6 years, 5 months ago (2014-07-11 16:24:49 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/caseq@chromium.org/389563002/40001

6 years, 5 months ago (2014-07-14 08:10:30 UTC) #7

yurys

6 years, 5 months ago (2014-07-17 07:04:15 UTC) #9

Message was sent while issue was closed.

Looks like it broke inspector/layers/tracing-layer-tree.html

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40...

Expand Messages | Collapse Messages