Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1154)

Unified Diff: Source/devtools/front_end/timeline/TimelineTracingView.js

Issue 389563002: DevTools: make paint profiler target-aware (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: fixed a test and a stray line Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/timeline/TimelineTracingView.js
diff --git a/Source/devtools/front_end/timeline/TimelineTracingView.js b/Source/devtools/front_end/timeline/TimelineTracingView.js
index 0708159b46b04d565fa2e95c5e8cc2bd11635081..dd7e47f36f655e8358ad7768822f0aa9962d8584 100644
--- a/Source/devtools/front_end/timeline/TimelineTracingView.js
+++ b/Source/devtools/front_end/timeline/TimelineTracingView.js
@@ -122,13 +122,13 @@ WebInspector.TimelineTracingView.prototype = {
*/
function reveal()
{
- WebInspector.Revealer.reveal(new WebInspector.DeferredTracingLayerTree(this._tracingModel.target(), record.args["snapshot"]["active_tree"]["root_layer"], record.args["snapshot"]["device_viewport_size"]));
+ WebInspector.Revealer.reveal(new WebInspector.DeferredTracingLayerTree(this._tracingModel.target().weakReference(), record.args["snapshot"]["active_tree"]["root_layer"], record.args["snapshot"]["device_viewport_size"]));
}
/**
* @param {!Node=} node
* @this {WebInspector.TimelineTracingView}
*/
- function appendPreviewAndshowDetails(node)
+ function appendPreviewAndShowDetails(node)
{
if (node)
contentHelper.appendElementRow("Preview", node);
@@ -137,7 +137,7 @@ WebInspector.TimelineTracingView.prototype = {
var recordTypes = WebInspector.TracingTimelineModel.RecordType;
switch (record.name) {
case recordTypes.PictureSnapshot:
- WebInspector.TracingTimelineUIUtils.buildPicturePreviewContent(record.args["snapshot"]["skp64"], appendPreviewAndshowDetails.bind(this));
+ WebInspector.TracingTimelineUIUtils.buildPicturePreviewContent(this._tracingModel.target(), record.args["snapshot"]["skp64"], appendPreviewAndShowDetails.bind(this));
break;
case recordTypes.LayerTreeHostImplSnapshot:
var link = document.createElement("span");
« no previous file with comments | « Source/devtools/front_end/timeline/TimelinePanel.js ('k') | Source/devtools/front_end/timeline/TracingTimelineUIUtils.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698