Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Unified Diff: Source/bindings/scripts/generate_bindings.pl

Issue 38943008: Explore the possibility of implementing the CSS Region interface. Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/scripts/generate_bindings.pl
diff --git a/Source/bindings/scripts/generate_bindings.pl b/Source/bindings/scripts/generate_bindings.pl
index 35c2a916498085f37ddced9c4ef66369898b650b..1dcb77dc46ac9cae7cb70642a9b96bb72d0ec8eb 100755
--- a/Source/bindings/scripts/generate_bindings.pl
+++ b/Source/bindings/scripts/generate_bindings.pl
@@ -96,7 +96,7 @@ if ($interfaceDependenciesFile) {
$idlFound = grep { $_ and basename($_) eq basename($targetIdlFile) } @idlFiles;
}
- if (!$idlFound) {
+ if (!$idlFound and !($targetInterfaceName eq "CSSRegion")) {
abucur 2013/10/25 16:54:57 This hack is necessary to allow the generation of
abarth-chromium 2013/10/25 16:57:24 not lgtm due to this hack. I think you've also go
Inactive 2013/10/25 17:48:50 If you want V8CSSRegion to be generated then CSSRe
# IDL files for dependencies (partial interfaces and interfaces
# implemented elsewhere). We generate empty .h and .cpp files just to
# tell build scripts that outputs have been created.

Powered by Google App Engine
This is Rietveld 408576698