Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Side by Side Diff: Source/bindings/scripts/generate_bindings.pl

Issue 38943008: Explore the possibility of implementing the CSS Region interface. Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 #!/usr/bin/perl -w 1 #!/usr/bin/perl -w
2 # 2 #
3 # Copyright (C) 2005 Apple Computer, Inc. 3 # Copyright (C) 2005 Apple Computer, Inc.
4 # Copyright (C) 2006 Anders Carlsson <andersca@mac.com> 4 # Copyright (C) 2006 Anders Carlsson <andersca@mac.com>
5 # 5 #
6 # This file is part of WebKit 6 # This file is part of WebKit
7 # 7 #
8 # This library is free software; you can redistribute it and/or 8 # This library is free software; you can redistribute it and/or
9 # modify it under the terms of the GNU Library General Public 9 # modify it under the terms of the GNU Library General Public
10 # License as published by the Free Software Foundation; either 10 # License as published by the Free Software Foundation; either
(...skipping 78 matching lines...) Expand 10 before | Expand all | Expand 10 after
89 close FH; 89 close FH;
90 90
91 # $additionalIdlFiles is for IDL files not listed in the interface 91 # $additionalIdlFiles is for IDL files not listed in the interface
92 # dependencies file, namely generated IDL files for interfaces 92 # dependencies file, namely generated IDL files for interfaces
93 # (not partial interfaces), so we need to generate .h and .cpp files. 93 # (not partial interfaces), so we need to generate .h and .cpp files.
94 if (!$idlFound and $additionalIdlFiles) { 94 if (!$idlFound and $additionalIdlFiles) {
95 my @idlFiles = shellwords($additionalIdlFiles); 95 my @idlFiles = shellwords($additionalIdlFiles);
96 $idlFound = grep { $_ and basename($_) eq basename($targetIdlFile) } @id lFiles; 96 $idlFound = grep { $_ and basename($_) eq basename($targetIdlFile) } @id lFiles;
97 } 97 }
98 98
99 if (!$idlFound) { 99 if (!$idlFound and !($targetInterfaceName eq "CSSRegion")) {
abucur 2013/10/25 16:54:57 This hack is necessary to allow the generation of
abarth-chromium 2013/10/25 16:57:24 not lgtm due to this hack. I think you've also go
Inactive 2013/10/25 17:48:50 If you want V8CSSRegion to be generated then CSSRe
100 # IDL files for dependencies (partial interfaces and interfaces 100 # IDL files for dependencies (partial interfaces and interfaces
101 # implemented elsewhere). We generate empty .h and .cpp files just to 101 # implemented elsewhere). We generate empty .h and .cpp files just to
102 # tell build scripts that outputs have been created. 102 # tell build scripts that outputs have been created.
103 generateEmptyHeaderAndCpp($targetInterfaceName, $outputDirectory); 103 generateEmptyHeaderAndCpp($targetInterfaceName, $outputDirectory);
104 exit 0; 104 exit 0;
105 } 105 }
106 } 106 }
107 107
108 # Parse the target IDL file. 108 # Parse the target IDL file.
109 my $targetParser = idl_parser->new(!$verbose); 109 my $targetParser = idl_parser->new(!$verbose);
(...skipping 187 matching lines...) Expand 10 before | Expand all | Expand 10 after
297 last OUTER; 297 last OUTER;
298 } 298 }
299 } 299 }
300 } 300 }
301 if ($error) { 301 if ($error) {
302 die "IDL ATTRIBUTE CHECKER ERROR: $error 302 die "IDL ATTRIBUTE CHECKER ERROR: $error
303 If you want to add a new IDL attribute, you need to add it to bindings/scripts/I DLAttributes.txt and add explanations to the Blink IDL document (http://chromium .org/blink/webidl). 303 If you want to add a new IDL attribute, you need to add it to bindings/scripts/I DLAttributes.txt and add explanations to the Blink IDL document (http://chromium .org/blink/webidl).
304 "; 304 ";
305 } 305 }
306 } 306 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698