Source/web/ValidationMessageClientImpl.h - Issue 389343002: Custom validation message to take into account text direction

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/ValidationMessageClientImpl.h

Issue 389343002: Custom validation message to take into account text direction (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Removed |dir| value read. Updated tests to use setDirection. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/html/HTMLFormControlElementTest.cpp ('K') | « Source/core/page/ValidationMessageClient.h ('k') | Source/web/ValidationMessageClientImpl.cpp » ('j') | public/web/WebViewClient.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/web/ValidationMessageClientImpl.h

diff --git a/Source/web/ValidationMessageClientImpl.h b/Source/web/ValidationMessageClientImpl.h

index bad73ecf011d596689b687904f6e46cb3bb19c72..1a2693881de3b4fbb8b96e5830d1252cd8d6ac5e 100644

--- a/Source/web/ValidationMessageClientImpl.h

+++ b/Source/web/ValidationMessageClientImpl.h

@@ -53,7 +53,7 @@ private:

void checkAnchorStatus(blink::Timer<ValidationMessageClientImpl>*);

blink::FrameView* currentView();

- virtual void showValidationMessage(const blink::Element& anchor, const String& message) OVERRIDE;

+ virtual void showValidationMessage(const blink::Element& anchor, const String& message, blink::TextDirection messageDir, const String& subMessage, blink::TextDirection subMessageDir) OVERRIDE;

tkent 2014/08/11 01:45:49 Please remove blink:: prefixes.

Habib Virji 2014/08/11 20:34:29 Done.

virtual void hideValidationMessage(const blink::Element& anchor) OVERRIDE;

virtual bool isValidationMessageVisible(const blink::Element& anchor) OVERRIDE;

virtual void documentDetached(const blink::Document&) OVERRIDE;