Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Side by Side Diff: Source/web/ValidationMessageClientImpl.h

Issue 389343002: Custom validation message to take into account text direction (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Removed |dir| value read. Updated tests to use setDirection. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
46 static PassOwnPtrWillBeRawPtr<ValidationMessageClientImpl> create(WebViewImp l&); 46 static PassOwnPtrWillBeRawPtr<ValidationMessageClientImpl> create(WebViewImp l&);
47 virtual ~ValidationMessageClientImpl(); 47 virtual ~ValidationMessageClientImpl();
48 48
49 virtual void trace(blink::Visitor*) OVERRIDE; 49 virtual void trace(blink::Visitor*) OVERRIDE;
50 50
51 private: 51 private:
52 ValidationMessageClientImpl(WebViewImpl&); 52 ValidationMessageClientImpl(WebViewImpl&);
53 void checkAnchorStatus(blink::Timer<ValidationMessageClientImpl>*); 53 void checkAnchorStatus(blink::Timer<ValidationMessageClientImpl>*);
54 blink::FrameView* currentView(); 54 blink::FrameView* currentView();
55 55
56 virtual void showValidationMessage(const blink::Element& anchor, const Strin g& message) OVERRIDE; 56 virtual void showValidationMessage(const blink::Element& anchor, const Strin g& message, blink::TextDirection messageDir, const String& subMessage, blink::Te xtDirection subMessageDir) OVERRIDE;
tkent 2014/08/11 01:45:49 Please remove blink:: prefixes.
Habib Virji 2014/08/11 20:34:29 Done.
57 virtual void hideValidationMessage(const blink::Element& anchor) OVERRIDE; 57 virtual void hideValidationMessage(const blink::Element& anchor) OVERRIDE;
58 virtual bool isValidationMessageVisible(const blink::Element& anchor) OVERRI DE; 58 virtual bool isValidationMessageVisible(const blink::Element& anchor) OVERRI DE;
59 virtual void documentDetached(const blink::Document&) OVERRIDE; 59 virtual void documentDetached(const blink::Document&) OVERRIDE;
60 virtual void willBeDestroyed() OVERRIDE; 60 virtual void willBeDestroyed() OVERRIDE;
61 61
62 WebViewImpl& m_webView; 62 WebViewImpl& m_webView;
63 RawPtrWillBeMember<const blink::Element> m_currentAnchor; 63 RawPtrWillBeMember<const blink::Element> m_currentAnchor;
64 String m_message; 64 String m_message;
65 blink::IntRect m_lastAnchorRectInScreen; 65 blink::IntRect m_lastAnchorRectInScreen;
66 float m_lastPageScaleFactor; 66 float m_lastPageScaleFactor;
67 double m_finishTime; 67 double m_finishTime;
68 blink::Timer<ValidationMessageClientImpl> m_timer; 68 blink::Timer<ValidationMessageClientImpl> m_timer;
69 }; 69 };
70 70
71 } 71 }
72 72
73 #endif 73 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698