Chromium Code Reviews Chromium Code Reviews
Issue 389343002:
Custom validation message to take into account text direction (Closed)
Base URL: https://chromium.googlesource.com/chromium/blink.git@master| Index: Source/core/html/HTMLFormControlElementTest.cpp |
| diff --git a/Source/core/html/HTMLFormControlElementTest.cpp b/Source/core/html/HTMLFormControlElementTest.cpp |
| new file mode 100644 |
| index 0000000000000000000000000000000000000000..58a446ce5b87dfab149fc704898cbd9baa369a8e |
| --- /dev/null |
| +++ b/Source/core/html/HTMLFormControlElementTest.cpp |
| @@ -0,0 +1,72 @@ |
| +// Copyright 2014 The Chromium Authors. All rights reserved. |
| +// Use of this source code is governed by a BSD-style license that can be |
| +// found in the LICENSE file. |
| + |
| +#include "config.h" |
| +#include "core/html/HTMLFormControlElement.h" |
| + |
| +#include "core/frame/FrameView.h" |
| +#include "core/html/HTMLDocument.h" |
| +#include "core/html/HTMLInputElement.h" |
| +#include "core/testing/DummyPageHolder.h" |
| +#include <gtest/gtest.h> |
| + |
| +using namespace blink; |
|
tkent
2014/08/11 01:45:48
We may simply use blink namespace like:
namespace
Habib Virji
2014/08/11 20:34:29
Done.
|
| + |
| +namespace { |
| + |
| +class HTMLFormControlElementTest : public ::testing::Test { |
| +protected: |
| + virtual void SetUp() OVERRIDE; |
| + |
| + DummyPageHolder& page() const { return *m_dummyPageHolder; } |
| + HTMLDocument& document() const { return *m_document; } |
| + |
| +private: |
| + OwnPtr<DummyPageHolder> m_dummyPageHolder; |
| + RefPtrWillBePersistent<HTMLDocument> m_document; |
| +}; |
| + |
| +void HTMLFormControlElementTest::SetUp() |
| +{ |
| + Page::PageClients pageClients; |
| + fillWithEmptyClients(pageClients); |
| + m_dummyPageHolder = DummyPageHolder::create(IntSize(800, 600), &pageClients); |
| + |
| + m_document = toHTMLDocument(&m_dummyPageHolder->document()); |
| + m_document->setMimeType("text/html"); |
| + m_document->setCharset("utf-8"); |
| + m_document->documentElement()->setInnerHTML("<body><input required id=input></body>", ASSERT_NO_EXCEPTION); |
|
tkent
2014/08/11 01:45:49
Please move setInnerHTML call to the TEST_F.
HTMLF
Habib Virji
2014/08/11 20:34:29
Done.
|
| + m_document->view()->updateLayoutAndStyleIfNeededRecursive(); |
| +} |
| + |
| +TEST_F(HTMLFormControlElementTest, customValidationMessageTextDirection) |
| +{ |
| + SetUp(); |
|
tkent
2014/08/11 01:45:48
Do not call SetUp(). It is automatically called.
Habib Virji
2014/08/11 20:34:29
Done.
|
| + |
| + HTMLInputElement* input = toHTMLInputElement(document().getElementById("input")); |
| + input->setCustomValidity(String::fromUTF8("عربى")); |
|
tkent
2014/08/11 01:45:48
Please do not write non-ASCII characters in source
Habib Virji
2014/08/11 20:34:29
Done.
|
| + input->setAttribute(HTMLNames::titleAttr, AtomicString::fromUTF8("عربى")); |
| + |
| + String message = input->validationMessage().stripWhiteSpace(); |
| + String subMessage = String(); |
| + TextDirection messageDir = RTL; |
| + TextDirection subMessageDir = LTR; |
| + |
| + input->findCustomValidationMessageTextDirection(message, messageDir, subMessage, subMessageDir); |
| + EXPECT_EQ(messageDir, RTL); |
| + EXPECT_EQ(subMessageDir, LTR); |
| + |
| + input->renderer()->style()->setDirection(RTL); |
| + input->findCustomValidationMessageTextDirection(message, messageDir, subMessage, subMessageDir); |
| + EXPECT_EQ(messageDir, RTL); |
| + EXPECT_EQ(subMessageDir, RTL); |
| + |
| + input->setCustomValidity(String::fromUTF8("Main message.")); |
| + message = input->validationMessage().stripWhiteSpace(); |
| + input->findCustomValidationMessageTextDirection(message, messageDir, subMessage, subMessageDir); |
| + EXPECT_EQ(messageDir, LTR); |
| + EXPECT_EQ(subMessageDir, RTL); |
| +} |
| + |
| +} |
