Source/core/page/ValidationMessageClient.h - Issue 389343002: Custom validation message to take into account text direction

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/page/ValidationMessageClient.h

Issue 389343002: Custom validation message to take into account text direction (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Compilation and Levi's firstStrong changes Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/page/ValidationMessageClient.h

diff --git a/Source/core/page/ValidationMessageClient.h b/Source/core/page/ValidationMessageClient.h

index ae2354cd578779bb3d6a26f62cf3ae61fd1db157..03e4a9fcc97fd2a60a6de1ef1c2070577bc63735 100644

--- a/Source/core/page/ValidationMessageClient.h

+++ b/Source/core/page/ValidationMessageClient.h

@@ -41,7 +41,7 @@ public:

// Show validation message for the specified anchor element. An

// implementation of this function may hide the message automatically after

// some period.

- virtual void showValidationMessage(const Element& anchor, const String& message) = 0;

+ virtual void showValidationMessage(const Element& anchor, const String& message, bool customError) = 0;

leviw_travelin_and_unemployed 2014/07/16 04:26:22 boolean parameters make me sad. Can we use somethi

Habib Virji 2014/07/16 13:32:02 I have introduced enum type and removed boolean no

// Hide validation message for the specified anchor if the message for the

// anchor is already visible.

« no previous file with comments | « Source/core/html/HTMLFormControlElement.cpp ('k') | Source/web/ValidationMessageClientImpl.h » ('j') | Source/web/ValidationMessageClientImpl.cpp » ('J')