Custom validation message to take into account text direction

Source/core/page/ValidationMessageClient.h

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
  *     notice, this list of conditions and the following disclaimer in the
@@ skipping 23 matching lines @@
 class Document;
 class Element;
 
 class ValidationMessageClient : public WillBeGarbageCollectedMixin {
 public:
     virtual ~ValidationMessageClient() { }
 
     // Show validation message for the specified anchor element. An
     // implementation of this function may hide the message automatically after
     // some period.
-    virtual void showValidationMessage(const Element& anchor, const String& message) = 0;
+    virtual void showValidationMessage(const Element& anchor, const String& message, bool customError) = 0;

[leviw_travelin_and_unemployed, 2014/07/16 04:26:22]

boolean parameters make me sad. Can we use something else like an enum?

[Habib Virji, 2014/07/16 13:32:02]

I have introduced enum type and removed boolean now. 

 
     // Hide validation message for the specified anchor if the message for the
     // anchor is already visible.
     virtual void hideValidationMessage(const Element& anchor) = 0;
 
     // Returns true if the validation message for the specified anchor element
     // is visible.
     virtual bool isValidationMessageVisible(const Element& anchor) = 0;
 
     virtual void documentDetached(const Document&) = 0;
 
     virtual void willBeDestroyed() = 0;
 
     virtual void trace(Visitor*) { }
 };
 
 }
 
 #endif