|
Revert 282900 "Revert 282890 "[fsp] Add an option for mounting i..."
Unable to reproduce locally even on a Debug build. Reverting the revert and
monitoring carefully.
> Revert 282890 "[fsp] Add an option for mounting in R/W mode."
>
> > [fsp] Add an option for mounting in R/W mode.
> >
> > Files app fetches information whether a volume is read only or R/W from
> > file_manager::VolumeManager, which used to always have the isReadOnly option
> > set to true for any provided file system.
> >
> > However, since R/W operations are now under development, we should be able to
> > mark a volume as R/W.
> >
> > In order to achieve that, a "writable" option has been added to the File System
> > Provider API mount() call. The argument is by default false, so file systems
> > are by default read only.
> >
> > TEST=unit_test, browser_tests: *FileSystemProvider*Writable*
> > BUG= 391362
> >
> > Review URL: https://codereview.chromium.org/372163006
>
> TBR=mtomasz@chromium.org
>
> Review URL: https://codereview.chromium.org/391613002
TBR=mtomasz@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282908
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+153 lines, -59 lines) |
Patch |
 |
M |
trunk/src/chrome/browser/chromeos/extensions/file_system_provider/file_system_provider_api.cc
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
 |
M |
trunk/src/chrome/browser/chromeos/file_manager/volume_manager.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
trunk/src/chrome/browser/chromeos/file_system_provider/fileapi/file_stream_reader_unittest.cc
|
View
|
|
1 chunk |
+4 lines, -2 lines |
0 comments
|
Download
|
 |
M |
trunk/src/chrome/browser/chromeos/file_system_provider/fileapi/provider_async_file_util_unittest.cc
|
View
|
|
1 chunk |
+4 lines, -2 lines |
0 comments
|
Download
|
 |
M |
trunk/src/chrome/browser/chromeos/file_system_provider/mount_path_util_unittest.cc
|
View
|
|
6 chunks |
+6 lines, -5 lines |
0 comments
|
Download
|
 |
M |
trunk/src/chrome/browser/chromeos/file_system_provider/operations/close_file_unittest.cc
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
trunk/src/chrome/browser/chromeos/file_system_provider/operations/create_directory_unittest.cc
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
trunk/src/chrome/browser/chromeos/file_system_provider/operations/delete_entry_unittest.cc
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
trunk/src/chrome/browser/chromeos/file_system_provider/operations/get_metadata_unittest.cc
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
trunk/src/chrome/browser/chromeos/file_system_provider/operations/open_file_unittest.cc
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
trunk/src/chrome/browser/chromeos/file_system_provider/operations/read_directory_unittest.cc
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
trunk/src/chrome/browser/chromeos/file_system_provider/operations/read_file_unittest.cc
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
trunk/src/chrome/browser/chromeos/file_system_provider/operations/unmount_unittest.cc
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
trunk/src/chrome/browser/chromeos/file_system_provider/provided_file_system_info.h
|
View
|
|
3 chunks |
+5 lines, -0 lines |
0 comments
|
Download
|
 |
M |
trunk/src/chrome/browser/chromeos/file_system_provider/provided_file_system_info.cc
|
View
|
|
1 chunk |
+2 lines, -0 lines |
0 comments
|
Download
|
 |
M |
trunk/src/chrome/browser/chromeos/file_system_provider/service.h
|
View
|
|
2 chunks |
+7 lines, -3 lines |
0 comments
|
Download
|
 |
M |
trunk/src/chrome/browser/chromeos/file_system_provider/service.cc
|
View
|
|
5 chunks |
+20 lines, -13 lines |
0 comments
|
Download
|
 |
M |
trunk/src/chrome/browser/chromeos/file_system_provider/service_unittest.cc
|
View
|
|
15 chunks |
+54 lines, -25 lines |
0 comments
|
Download
|
 |
M |
trunk/src/chrome/common/extensions/api/file_system_provider.idl
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
trunk/src/chrome/test/data/extensions/api_test/file_system_provider/mount/test.js
|
View
|
|
3 chunks |
+39 lines, -7 lines |
0 comments
|
Download
|
Total messages: 2 (0 generated)
|