[fsp] Add an option for mounting in R/W mode.

[fsp] Add an option for mounting in R/W mode.

Files app fetches information whether a volume is read only or R/W from
file_manager::VolumeManager, which used to always have the isReadOnly option
set to true for any provided file system.

However, since R/W operations are now under development, we should be able to
mark a volume as R/W.

In order to achieve that, a "writable" option has been added to the File System
Provider API mount() call. The argument is by default false, so file systems
are by default read only.

TEST=unit_test, browser_tests: *FileSystemProvider*Writable*
BUG=391362
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282890

[mtomasz, 2014-07-09 06:18:58]

@kinaba: PTAL. Thanks.

[kinaba, 2014-07-09 08:55:42]

lgtm

[mtomasz, 2014-07-09 09:19:21]

The CQ bit was checked by mtomasz@chromium.org

[mtomasz, 2014-07-09 09:19:42]

The CQ bit was unchecked by mtomasz@chromium.org

[mtomasz, 2014-07-09 09:20:30]

@kalman: PTAL at IDL. Let me know if you want me to remove that [nodoc].

[not at google - send to devlin, 2014-07-09 13:32:46]

lgtm

[mtomasz, 2014-07-09 13:52:35]

The CQ bit was checked by mtomasz@chromium.org

[commit-bot: I haz the power, 2014-07-09 13:53:33]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mtomasz@chromium.org/372163006/20001

[commit-bot: I haz the power, 2014-07-09 14:09:03]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/9...)
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)
  android_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/20...)
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  ios_dbg_simulator on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/bui...)
  ios_rel_device on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds...)
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)
  mac_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win8_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win8_chromium_rel/bui...)
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/26461)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/30900)

[commit-bot: I haz the power, 2014-07-09 14:10:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-09 14:10:40]

Try jobs failed on following builders:
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/26465)

[mtomasz, 2014-07-09 23:15:17]

The CQ bit was checked by mtomasz@chromium.org

[commit-bot: I haz the power, 2014-07-09 23:17:29]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mtomasz@chromium.org/372163006/20001

[commit-bot: I haz the power, 2014-07-10 00:25:52]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/9...)
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)
  android_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/20...)
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  ios_dbg_simulator on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/bui...)
  ios_rel_device on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds...)
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)
  mac_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win8_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win8_chromium_rel/bui...)
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/26763)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/31197)

[commit-bot: I haz the power, 2014-07-10 00:31:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-10 00:31:07]

Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)
  android_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/20...)
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  ios_dbg_simulator on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/bui...)
  ios_rel_device on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds...)
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/26801)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/31237)

[mtomasz, 2014-07-10 14:14:01]

The CQ bit was checked by mtomasz@chromium.org

[mtomasz, 2014-07-10 14:14:03]

The CQ bit was unchecked by mtomasz@chromium.org

[mtomasz, 2014-07-11 11:04:51]

The CQ bit was checked by mtomasz@chromium.org

[commit-bot: I haz the power, 2014-07-11 11:06:03]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mtomasz@chromium.org/372163006/40001

[commit-bot: I haz the power, 2014-07-11 12:43:01]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)

[commit-bot: I haz the power, 2014-07-11 13:50:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-11 13:50:30]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)

[mtomasz, 2014-07-11 15:51:14]

The CQ bit was checked by mtomasz@chromium.org

[commit-bot: I haz the power, 2014-07-11 15:51:51]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mtomasz@chromium.org/372163006/40001

[commit-bot: I haz the power, 2014-07-11 17:04:46]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)

[commit-bot: I haz the power, 2014-07-11 18:12:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-11 18:12:44]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)

[mtomasz, 2014-07-13 05:55:46]

The CQ bit was checked by mtomasz@chromium.org

[commit-bot: I haz the power, 2014-07-13 05:56:45]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mtomasz@chromium.org/372163006/40001

[commit-bot: I haz the power, 2014-07-13 07:04:20]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)

[commit-bot: I haz the power, 2014-07-13 08:15:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-13 08:15:14]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)

[mtomasz, 2014-07-14 00:50:29]

The CQ bit was checked by mtomasz@chromium.org

[commit-bot: I haz the power, 2014-07-14 00:50:53]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mtomasz@chromium.org/372163006/60001

[commit-bot: I haz the power, 2014-07-14 02:36:20]

Change committed as 282890

[falken, 2014-07-14 03:55:31]

On 2014/07/14 02:36:20, I haz the power (commit-bot) wrote:
> Change committed as 282890

I think this caused FileSystemProviderApiTest.Mount to fail on Linux ChromiumOS
Tests:
http://build.chromium.org/p/chromium.webkit/builders/Linux%20ChromiumOS%20Tes...

[8391:8391:0713/203712:INFO:CONSOLE(0)] "[FAIL] successfulWritableMount:
uncaught exception: Invalid value for argument 1. Property 'writable':
Unexpected property.
Error
    at extensions::test:96:22
    at Object.exports.handle (extensions::uncaught_exception_handler:15:3)
    at Object.\u003Canonymous> (extensions::test:100:32)
    at Object.handleRequest (extensions::binding:55:27)
    at Object.\u003Canonymous> (extensions::binding:318:32)", source:
chrome-extension://ddammdhioacbehjngdmkjcjbnfginlla/_generated_background_page.html
(0)
[8391:8391:0713/203712:INFO:CONSOLE(119)] "Uncaught chrome.test.failure",
source: extensions::test (119)
[8391:8391:0713/203712:INFO:CONSOLE(0)] "[FAIL] stressMountTest: FAIL (no
message)
Error
    at chrome-extension://ddammdhioacbehjngdmkjcjbnfginlla/test.js:138:27
    at Object.customCallback (extensions::fileSystemProvider:97:11)
    at safeCallbackApply (extensions::sendRequest:22:15)
    at handleResponse (extensions::sendRequest:61:7)", source:
chrome-extension://ddammdhioacbehjngdmkjcjbnfginlla/_generated_background_page.html
(0)
../../chrome/browser/chromeos/extensions/file_system_provider/file_system_provider_apitest.cc:31:
Failure
Value of: RunPlatformAppTestWithFlags("file_system_provider/mount",
kFlagLoadAsComponent)
  Actual: false
Expected: true
Failed 2 of 6 tests