Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 389043002: Oilpan: move FetchBodyStream to the heap. (Closed)

Created:
6 years, 5 months ago by sof
Modified:
6 years, 5 months ago
Reviewers:
oilpan-reviews, haraken
CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, nhiroki, falken, kinuko+serviceworker, horo+watch_chromium.org, alecflett+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Oilpan: move FetchBodyStream to the heap. Followup r177958 and move FetchBodyStream to the heap also. R=haraken@chromium.org BUG=340522 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178002

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -11 lines) Patch
M Source/modules/serviceworkers/FetchBodyStream.h View 4 chunks +10 lines, -4 lines 0 comments Download
M Source/modules/serviceworkers/FetchBodyStream.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/serviceworkers/FetchBodyStream.idl View 1 chunk +2 lines, -1 line 0 comments Download
M Source/modules/serviceworkers/Response.h View 2 chunks +2 lines, -3 lines 0 comments Download
M Source/modules/serviceworkers/Response.cpp View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
sof
Please take a look.
6 years, 5 months ago (2014-07-12 17:00:23 UTC) #1
haraken
LGTM
6 years, 5 months ago (2014-07-12 17:09:41 UTC) #2
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 5 months ago (2014-07-12 18:25:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/389043002/1
6 years, 5 months ago (2014-07-12 18:26:23 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_gpu on tryserver.chromium.gpu ...
6 years, 5 months ago (2014-07-12 19:29:20 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-12 20:19:32 UTC) #6
Message was sent while issue was closed.
Change committed as 178002

Powered by Google App Engine
This is Rietveld 408576698