Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Unified Diff: Source/modules/serviceworkers/FetchBodyStream.h

Issue 389043002: Oilpan: move FetchBodyStream to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/modules/serviceworkers/FetchBodyStream.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/serviceworkers/FetchBodyStream.h
diff --git a/Source/modules/serviceworkers/FetchBodyStream.h b/Source/modules/serviceworkers/FetchBodyStream.h
index ff2101779e6dd95be152341ee7e001bf6d6e7ac3..08773466aafa60c86756c4f7071b81096214ad7a 100644
--- a/Source/modules/serviceworkers/FetchBodyStream.h
+++ b/Source/modules/serviceworkers/FetchBodyStream.h
@@ -12,6 +12,7 @@
#include "core/fileapi/FileReaderLoader.h"
#include "core/fileapi/FileReaderLoaderClient.h"
#include "platform/blob/BlobData.h"
+#include "platform/heap/Handle.h"
#include "wtf/RefCounted.h"
#include "wtf/RefPtr.h"
@@ -19,9 +20,12 @@ namespace WebCore {
class ScriptState;
-class FetchBodyStream
- : public ScriptWrappable
- , public RefCounted<FetchBodyStream>
+// FIXME: Oilpan: when the implementation stops using
+// ActiveDOMObject::(un)setPendingActivity, derive from
+// RefCountedWillBeGarbageCollectedFinalized instead.
+class FetchBodyStream FINAL
+ : public RefCountedWillBeRefCountedGarbageCollected<FetchBodyStream>
+ , public ScriptWrappable
, public ActiveDOMObject
, public FileReaderLoaderClient {
public:
@@ -33,7 +37,7 @@ public:
ResponseAsText
};
- static PassRefPtr<FetchBodyStream> create(ExecutionContext*, PassRefPtr<BlobDataHandle>);
+ static PassRefPtrWillBeRawPtr<FetchBodyStream> create(ExecutionContext*, PassRefPtr<BlobDataHandle>);
~FetchBodyStream() { }
ScriptPromise asArrayBuffer(ScriptState*);
@@ -45,6 +49,8 @@ public:
// ActiveDOMObject override.
virtual void stop() OVERRIDE;
+ void trace(Visitor*) { }
+
private:
FetchBodyStream(ExecutionContext*, PassRefPtr<BlobDataHandle>);
ScriptPromise readAsync(ScriptState*, ResponseType);
« no previous file with comments | « no previous file | Source/modules/serviceworkers/FetchBodyStream.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698