Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Unified Diff: tools/json_schema_compiler/test/simple_api_unittest.cc

Issue 388963002: Get rid of the rest of CreateStringValue (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: tweaks Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/json_schema_compiler/test/simple_api_unittest.cc
diff --git a/tools/json_schema_compiler/test/simple_api_unittest.cc b/tools/json_schema_compiler/test/simple_api_unittest.cc
index f34b9fc258201e02554b59bebe55119e846f29ea..0e291449c73620b729d27c4048da5f6756554a37 100644
--- a/tools/json_schema_compiler/test/simple_api_unittest.cc
+++ b/tools/json_schema_compiler/test/simple_api_unittest.cc
@@ -16,8 +16,7 @@ static scoped_ptr<base::DictionaryValue> CreateTestTypeDictionary() {
base::Value::CreateDoubleValue(1.1));
value->SetWithoutPathExpansion("integer",
base::Value::CreateIntegerValue(4));
- value->SetWithoutPathExpansion("string",
- base::Value::CreateStringValue("bling"));
+ value->SetWithoutPathExpansion("string", new base::StringValue("bling"));
value->SetWithoutPathExpansion("boolean",
base::Value::CreateBooleanValue(true));
return value.Pass();
@@ -44,8 +43,8 @@ TEST(JsonSchemaCompilerSimpleTest, IncrementIntegerParamsCreate) {
TEST(JsonSchemaCompilerSimpleTest, NumberOfParams) {
{
scoped_ptr<base::ListValue> params_value(new base::ListValue());
- params_value->Append(base::Value::CreateStringValue("text"));
- params_value->Append(base::Value::CreateStringValue("text"));
+ params_value->Append(new base::StringValue("text"));
+ params_value->Append(new base::StringValue("text"));
scoped_ptr<OptionalString::Params> params(
OptionalString::Params::Create(*params_value));
EXPECT_FALSE(params.get());
@@ -68,7 +67,7 @@ TEST(JsonSchemaCompilerSimpleTest, OptionalStringParamsCreate) {
}
{
scoped_ptr<base::ListValue> params_value(new base::ListValue());
- params_value->Append(base::Value::CreateStringValue("asdf"));
+ params_value->Append(new base::StringValue("asdf"));
scoped_ptr<OptionalString::Params> params(
OptionalString::Params::Create(*params_value));
EXPECT_TRUE(params.get());
@@ -102,7 +101,7 @@ TEST(JsonSchemaCompilerSimpleTest, OptionalBeforeRequired) {
{
scoped_ptr<base::ListValue> params_value(new base::ListValue());
params_value->Append(base::Value::CreateNullValue());
- params_value->Append(base::Value::CreateStringValue("asdf"));
+ params_value->Append(new base::StringValue("asdf"));
scoped_ptr<OptionalBeforeRequired::Params> params(
OptionalBeforeRequired::Params::Create(*params_value));
EXPECT_TRUE(params.get());
@@ -163,7 +162,7 @@ TEST(JsonSchemaCompilerSimpleTest, OnStringFiredCreate) {
{
scoped_ptr<base::ListValue> results(OnStringFired::Create("yo dawg"));
base::ListValue expected;
- expected.Append(base::Value::CreateStringValue("yo dawg"));
+ expected.Append(new base::StringValue("yo dawg"));
EXPECT_TRUE(results->Equals(&expected));
}
}

Powered by Google App Engine
This is Rietveld 408576698