Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Unified Diff: tools/json_schema_compiler/test/objects_unittest.cc

Issue 388963002: Get rid of the rest of CreateStringValue (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: tweaks Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/json_schema_compiler/test/objects_unittest.cc
diff --git a/tools/json_schema_compiler/test/objects_unittest.cc b/tools/json_schema_compiler/test/objects_unittest.cc
index c0af2e12c6a998ce7b2604aa29f99f38ece31d5d..69ce97a01f0ce7fcace7bbee9692bdbddc4a647f 100644
--- a/tools/json_schema_compiler/test/objects_unittest.cc
+++ b/tools/json_schema_compiler/test/objects_unittest.cc
@@ -12,8 +12,8 @@ using namespace test::api::objects;
TEST(JsonSchemaCompilerObjectsTest, ObjectParamParamsCreate) {
{
scoped_ptr<base::ListValue> strings(new base::ListValue());
- strings->Append(base::Value::CreateStringValue("one"));
- strings->Append(base::Value::CreateStringValue("two"));
+ strings->Append(new base::StringValue("one"));
+ strings->Append(new base::StringValue("two"));
scoped_ptr<base::DictionaryValue> info_value(new base::DictionaryValue());
info_value->Set("strings", strings.release());
info_value->Set("integer", base::Value::CreateIntegerValue(5));
@@ -32,8 +32,8 @@ TEST(JsonSchemaCompilerObjectsTest, ObjectParamParamsCreate) {
}
{
scoped_ptr<base::ListValue> strings(new base::ListValue());
- strings->Append(base::Value::CreateStringValue("one"));
- strings->Append(base::Value::CreateStringValue("two"));
+ strings->Append(new base::StringValue("one"));
+ strings->Append(new base::StringValue("two"));
scoped_ptr<base::DictionaryValue> info_value(new base::DictionaryValue());
info_value->Set("strings", strings.release());
info_value->Set("integer", base::Value::CreateIntegerValue(5));

Powered by Google App Engine
This is Rietveld 408576698