Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3183)

Unified Diff: base/values.h

Issue 388963002: Get rid of the rest of CreateStringValue (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: tweaks Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/values.h
diff --git a/base/values.h b/base/values.h
index c478e3ac79e199ca4a79540ac29a59850789f632..1c8e642ca5ab158901dbb338ab95338394244931 100644
--- a/base/values.h
+++ b/base/values.h
@@ -42,9 +42,7 @@ class Value;
typedef std::vector<Value*> ValueVector;
typedef std::map<std::string, Value*> ValueMap;
-// The Value class is the base class for Values. A Value can be instantiated
-// via the Create*Value() factory methods, or by directly creating instances of
-// the subclasses.
+// The Value class is the base class for Values.
//
// See the file-level comment above for more information.
class BASE_EXPORT Value {
@@ -69,8 +67,6 @@ class BASE_EXPORT Value {
static FundamentalValue* CreateBooleanValue(bool in_value);
static FundamentalValue* CreateIntegerValue(int in_value);
static FundamentalValue* CreateDoubleValue(double in_value);
- static StringValue* CreateStringValue(const std::string& in_value);
- static StringValue* CreateStringValue(const string16& in_value);
// Returns the type of the value stored by the current Value object.
// Each type will be implemented by only one subclass of Value, so it's

Powered by Google App Engine
This is Rietveld 408576698