Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Unified Diff: base/values.cc

Issue 388963002: Get rid of the rest of CreateStringValue (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: tweaks Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/values.cc
diff --git a/base/values.cc b/base/values.cc
index f27c09567eee61c55aafa398d9302a7bd8faeeac..6bb57a2c6bdc13a1f6fa0c057e9c15f0f289851e 100644
--- a/base/values.cc
+++ b/base/values.cc
@@ -104,16 +104,6 @@ FundamentalValue* Value::CreateDoubleValue(double in_value) {
return new FundamentalValue(in_value);
}
-// static
-StringValue* Value::CreateStringValue(const std::string& in_value) {
- return new StringValue(in_value);
-}
-
-// static
-StringValue* Value::CreateStringValue(const string16& in_value) {
- return new StringValue(in_value);
-}
-
bool Value::GetAsBoolean(bool* out_value) const {
return false;
}

Powered by Google App Engine
This is Rietveld 408576698