tools/json_schema_compiler/test/idl_schemas_unittest.cc - Issue 388963002: Get rid of the rest of CreateStringValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/json_schema_compiler/test/idl_schemas_unittest.cc

Issue 388963002: Get rid of the rest of CreateStringValue (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix bad rebase Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/json_schema_compiler/test/idl_schemas_unittest.cc

diff --git a/tools/json_schema_compiler/test/idl_schemas_unittest.cc b/tools/json_schema_compiler/test/idl_schemas_unittest.cc

index 728d7d4912144940d2ea075584dcef22b30fb37a..1817afb50db1e47cf86156be2ecd266150525cc9 100644

--- a/tools/json_schema_compiler/test/idl_schemas_unittest.cc

+++ b/tools/json_schema_compiler/test/idl_schemas_unittest.cc

@@ -92,7 +92,7 @@ TEST(IdlCompiler, OptionalArguments) {

scoped_ptr<Function8::Params> f8_params = Function8::Params::Create(list);

EXPECT_EQ(8, f8_params->arg1);

EXPECT_EQ(NULL, f8_params->arg2.get());

- list.Append(base::Value::CreateStringValue("foo"));

+ list.Append(new base::StringValue("foo"));

f8_params = Function8::Params::Create(list);

EXPECT_EQ(8, f8_params->arg1);

EXPECT_EQ("foo", *(f8_params->arg2));