extensions/renderer/dom_activity_logger.cc - Issue 388963002: Get rid of the rest of CreateStringValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/dom_activity_logger.cc

Issue 388963002: Get rid of the rest of CreateStringValue (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix bad rebase Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/renderer/dom_activity_logger.cc

diff --git a/extensions/renderer/dom_activity_logger.cc b/extensions/renderer/dom_activity_logger.cc

index 2d8ca4667a122350ec3a63af72506a33579edc16..98408ee4576105b7d8ae417494858b2e12562094 100644

--- a/extensions/renderer/dom_activity_logger.cc

+++ b/extensions/renderer/dom_activity_logger.cc

@@ -112,7 +112,7 @@ void DOMActivityLogger::logEvent(const WebString& event_name,

scoped_ptr<base::ListValue> args(new base::ListValue);

std::string event_name_utf8 = event_name.utf8();

for (int i = 0; i < argc; ++i)

- args->Append(base::Value::CreateStringValue(argv[i]));

+ args->Append(new base::StringValue(argv[i]));

SendDomActionMessage(

event_name_utf8, url, title, DomActionType::METHOD, args.Pass());

}