components/policy/core/browser/configuration_policy_pref_store_unittest.cc - Issue 388963002: Get rid of the rest of CreateStringValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/policy/core/browser/configuration_policy_pref_store_unittest.cc

Issue 388963002: Get rid of the rest of CreateStringValue (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix bad rebase Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/policy/core/browser/configuration_policy_handler_unittest.cc ('k') | components/policy/core/common/async_policy_provider_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/policy/core/browser/configuration_policy_pref_store_unittest.cc

diff --git a/components/policy/core/browser/configuration_policy_pref_store_unittest.cc b/components/policy/core/browser/configuration_policy_pref_store_unittest.cc

index e307f98006c650729291767745fa192385ed4283..35d91ee01d2313b8d3c5c0e402f7bf4052884efe 100644

--- a/components/policy/core/browser/configuration_policy_pref_store_unittest.cc

+++ b/components/policy/core/browser/configuration_policy_pref_store_unittest.cc

@@ -52,8 +52,8 @@ TEST_F(ConfigurationPolicyPrefStoreListTest, GetDefault) {

TEST_F(ConfigurationPolicyPrefStoreListTest, SetValue) {

base::ListValue* in_value = new base::ListValue();

- in_value->Append(base::Value::CreateStringValue("test1"));

- in_value->Append(base::Value::CreateStringValue("test2,"));

+ in_value->Append(new base::StringValue("test1"));

+ in_value->Append(new base::StringValue("test2,"));

PolicyMap policy;

policy.Set(kTestPolicy, POLICY_LEVEL_MANDATORY,

POLICY_SCOPE_USER, in_value, NULL);

@@ -80,9 +80,11 @@ TEST_F(ConfigurationPolicyPrefStoreStringTest, GetDefault) {

TEST_F(ConfigurationPolicyPrefStoreStringTest, SetValue) {

PolicyMap policy;

- policy.Set(kTestPolicy, POLICY_LEVEL_MANDATORY,

+ policy.Set(kTestPolicy,

+ POLICY_LEVEL_MANDATORY,

POLICY_SCOPE_USER,

- base::Value::CreateStringValue("http://chromium.org"), NULL);

+ new base::StringValue("http://chromium.org"),

+ NULL);

UpdateProviderPolicy(policy);

const base::Value* value = NULL;

EXPECT_TRUE(store_->GetValue(kTestPref, &value));

@@ -189,7 +191,7 @@ TEST_F(ConfigurationPolicyPrefStoreRefreshTest, Refresh) {

policy.Set(kTestPolicy,

POLICY_LEVEL_MANDATORY,

POLICY_SCOPE_USER,

- base::Value::CreateStringValue("http://www.chromium.org"),

+ new base::StringValue("http://www.chromium.org"),

NULL);

UpdateProviderPolicy(policy);

observer_.VerifyAndResetChangedKey(kTestPref);