chrome/browser/ui/startup/startup_browser_creator_browsertest.cc - Issue 388963002: Get rid of the rest of CreateStringValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/startup/startup_browser_creator_browsertest.cc

Issue 388963002: Get rid of the rest of CreateStringValue (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix bad rebase Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/startup/startup_browser_creator_browsertest.cc

diff --git a/chrome/browser/ui/startup/startup_browser_creator_browsertest.cc b/chrome/browser/ui/startup/startup_browser_creator_browsertest.cc

index 6601490c82d556d434963db25ca6f9afc462a5b6..5697f8cb89e72fd989e0325ca7a8ba8e0f75647d 100644

--- a/chrome/browser/ui/startup/startup_browser_creator_browsertest.cc

+++ b/chrome/browser/ui/startup/startup_browser_creator_browsertest.cc

@@ -1411,8 +1411,8 @@ IN_PROC_BROWSER_TEST_F(StartupBrowserCreatorFirstRunTest,

SessionStartupPref::kPrefValueURLs),

NULL);

base::ListValue startup_urls;

- startup_urls.Append(base::Value::CreateStringValue(

- test_server()->GetURL("files/title1.html").spec()));

+ startup_urls.Append(

+ new base::StringValue(test_server()->GetURL("files/title1.html").spec()));

policy_map_.Set(policy::key::kRestoreOnStartupURLs,

policy::POLICY_LEVEL_MANDATORY, policy::POLICY_SCOPE_USER,

startup_urls.DeepCopy(), NULL);