Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2247)

Unified Diff: chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc

Issue 388963002: Get rid of the rest of CreateStringValue (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix bad rebase Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc
diff --git a/chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc b/chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc
index 063ba5e3bc3610b8e2dae62c279260097718a917..e03d85c9f2a59f2aeae554a2b75950bb45458a9d 100644
--- a/chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc
+++ b/chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc
@@ -552,9 +552,9 @@ TEST_F(CloudPrintProxyPolicyStartupTest, StartBrowserWithoutPolicy) {
SetTestingFactory(profile, CloudPrintProxyServiceFactoryForPolicyTest);
TestingPrefServiceSyncable* prefs = profile->GetTestingPrefService();
- prefs->SetUserPref(prefs::kCloudPrintEmail,
- base::Value::CreateStringValue(
- MockServiceIPCServer::EnabledUserId()));
+ prefs->SetUserPref(
+ prefs::kCloudPrintEmail,
+ new base::StringValue(MockServiceIPCServer::EnabledUserId()));
CommandLine command_line(CommandLine::NO_PROGRAM);
command_line.AppendSwitch(switches::kCheckCloudPrintConnectorPolicy);
@@ -600,9 +600,9 @@ TEST_F(CloudPrintProxyPolicyStartupTest, StartBrowserWithPolicy) {
SetTestingFactory(profile, CloudPrintProxyServiceFactoryForPolicyTest);
TestingPrefServiceSyncable* prefs = profile->GetTestingPrefService();
- prefs->SetUserPref(prefs::kCloudPrintEmail,
- base::Value::CreateStringValue(
- MockServiceIPCServer::EnabledUserId()));
+ prefs->SetUserPref(
+ prefs::kCloudPrintEmail,
+ new base::StringValue(MockServiceIPCServer::EnabledUserId()));
prefs->SetManagedPref(prefs::kCloudPrintProxyEnabled,
new base::FundamentalValue(false));

Powered by Google App Engine
This is Rietveld 408576698