Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 388923004: FileSystem: Move SnapshotFileCallback into FileSystemCallbacks.h (Closed)

Created:
6 years, 5 months ago by aandrey
Modified:
6 years, 5 months ago
Reviewers:
kinuko, nhiroki, yurys
CC:
blink-reviews, kinuko+fileapi, nhiroki, tzik
Project:
blink
Visibility:
Public.

Description

FileSystem: Move SnapshotFileCallback into FileSystemCallbacks.h This move also fixes the bug for FileEntry.file() operation. BUG=370100 R=kinuko@chromium.org, nhiroki@chromium.org, yurys Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178037

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -54 lines) Patch
M Source/modules/filesystem/DOMFileSystem.cpp View 2 chunks +0 lines, -53 lines 0 comments Download
M Source/modules/filesystem/FileSystemCallbacks.h View 2 chunks +13 lines, -0 lines 0 comments Download
M Source/modules/filesystem/FileSystemCallbacks.cpp View 4 chunks +43 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
aandrey
6 years, 5 months ago (2014-07-11 19:07:24 UTC) #1
nhiroki
lgtm
6 years, 5 months ago (2014-07-14 03:25:17 UTC) #2
aandrey
The CQ bit was checked by aandrey@chromium.org
6 years, 5 months ago (2014-07-14 07:26:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aandrey@chromium.org/388923004/1
6 years, 5 months ago (2014-07-14 07:27:01 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_compile_dbg on tryserver.blink ...
6 years, 5 months ago (2014-07-14 08:47:07 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-14 09:00:19 UTC) #6
Message was sent while issue was closed.
Change committed as 178037

Powered by Google App Engine
This is Rietveld 408576698