Issue 388803007: Add SkBitmap::readPixels() and reimplement copyTo and SkCanvas::readPixels

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 388803007: Add SkBitmap::readPixels() and reimplement copyTo and SkCanvas::readPixels (Closed)

Created:
6 years, 5 months ago by reed1

Modified:
6 years, 5 months ago

Reviewers:
reed2

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

More Reviews

Description

Add SkBitmap::readPixels() and reimplement copyTo and SkCanvas::readPixels usning it. Revert "Revert of add readPixels() to SkBitmap (https://codereview.chromium.org/377303002/)" This reverts commit d08cb905a7cc80d8fb868bbd14fffe1cd68adcce. TBR=scroggo@google.com Committed: https://skia.googlesource.com/skia/+/debba5c3d091159149f8a88ab5dcd44dd72e0dc7

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+346 lines, -141 lines)			Patch
M	include/core/SkBitmap.h	View	1 chunk	+22 lines, -0 lines	0 comments	Download
M	include/core/SkCanvas.h	View	1 chunk	+11 lines, -10 lines	0 comments	Download
M	src/core/SkBitmap.cpp	View	3 chunks	+71 lines, -56 lines	0 comments	Download
M	src/core/SkBitmapDevice.cpp	View	3 chunks	+2 lines, -74 lines	0 comments	Download
M	src/core/SkConfig8888.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/core/SkConfig8888.cpp	View	2 chunks	+142 lines, -0 lines	0 comments	Download
M	tests/BitmapCopyTest.cpp	View	2 chunks	+94 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@google.com/388803007/1

6 years, 5 months ago (2014-07-12 19:10:53 UTC) #2

commit-bot: I haz the power

Change committed as debba5c3d091159149f8a88ab5dcd44dd72e0dc7

6 years, 5 months ago (2014-07-12 19:26:43 UTC) #3

reed2

6 years, 5 months ago (2014-07-12 20:15:02 UTC) #4

Message was sent while issue was closed.

A revert of this CL has been created in
https://codereview.chromium.org/382543005/ by reed@chromium.org.

The reason for reverting is: still failing (randomly?) bench sometimes. need
stack dump to diagnose..

Expand Messages | Collapse Messages