[Mac] Replace SetOverlayView with AllowOtherViews.

[Mac] Replace SetOverlayView with AllowOtherViews.

This allows to remove weak pointers between different WebContents,
and pointer from DevToolsController to WebContents of DevToolsWindow.
The latter one proved to be stale sometimes and caused crashes.

Once bug 392031 is resolved, AllowOtherViews can be removed.

BUG=392914, 392917, 392971, 392031
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283553

[dgozman, 2014-07-11 13:56:04]

Could you please take a look?
ccameron@ - at rwhv_mac.
asvitkine@ - at chrome/browser/ui/cocoa.
jochen@ - at web_contents* (API change).

New method looks pretty similar to AllowOverlappingViews, but has different
meaning and usages. It seems that AllowOverlappingViews should be removed (as it
does nothing now), and AllowOtherViews will be the only one left (until
crbug.com/392031 is done).

[jochen (gone - plz use gerrit), 2014-07-14 11:15:24]

Avi is the better reviewer for this change

https://codereview.chromium.org/388803003/diff/70001/chrome/browser/ui/cocoa/...
File chrome/browser/ui/cocoa/dev_tools_controller_browsertest.mm (right):

https://codereview.chromium.org/388803003/diff/70001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/dev_tools_controller_browsertest.mm:24: ,
devtools_window_(NULL) {}
please clang-format

[ccameron, 2014-07-14 17:25:56]

Hopefully the CanPause... bit of logic will be gone in M38-M39 time. In the mean
time, this lgtm

[dgozman, 2014-07-15 06:03:02]

It would be nice to land this top crash fix to the next dev release.
Adding more reviewers, since Avi is away. 
jam@ as content owner.
thakis@, asvitkine@ for chrome/browser/ui/cocoa.

[Alexei Svitkine (slow), 2014-07-15 14:02:19]

https://codereview.chromium.org/388803003/diff/70001/chrome/browser/ui/cocoa/...
File chrome/browser/ui/cocoa/dev_tools_controller.mm (right):

https://codereview.chromium.org/388803003/diff/70001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/dev_tools_controller.mm:34: (const
DevToolsContentsResizingStrategy&)strategy;
Nit: Wrap before "withStrategy:" and align the :'s.

https://codereview.chromium.org/388803003/diff/70001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/dev_tools_controller.mm:43: -
(void)setDevToolsView:(NSView*)devToolsView withStrategy:
Nit: Ditto.

https://codereview.chromium.org/388803003/diff/70001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/dev_tools_controller.mm:137: NSView* devToolsView =
devTools ? devTools->GetNativeView() : nil;
Nit: Given that you have an "if (devTools)" right below, remove this conditional
and init this to nil here and put the other stmt inside the if.

https://codereview.chromium.org/388803003/diff/70001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/dev_tools_controller.mm:150: [devToolsContainerView_
setDevToolsView: devToolsView withStrategy: strategy];
Nit: Remove spaces after :'s.

[dgozman, 2014-07-15 14:38:42]

PTAL

https://codereview.chromium.org/388803003/diff/70001/chrome/browser/ui/cocoa/...
File chrome/browser/ui/cocoa/dev_tools_controller.mm (right):

https://codereview.chromium.org/388803003/diff/70001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/dev_tools_controller.mm:34: (const
DevToolsContentsResizingStrategy&)strategy;
On 2014/07/15 14:02:19, Alexei Svitkine wrote:
> Nit: Wrap before "withStrategy:" and align the :'s.

Done.

https://codereview.chromium.org/388803003/diff/70001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/dev_tools_controller.mm:43: -
(void)setDevToolsView:(NSView*)devToolsView withStrategy:
On 2014/07/15 14:02:19, Alexei Svitkine wrote:
> Nit: Ditto.

Done.

https://codereview.chromium.org/388803003/diff/70001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/dev_tools_controller.mm:137: NSView* devToolsView =
devTools ? devTools->GetNativeView() : nil;
On 2014/07/15 14:02:19, Alexei Svitkine wrote:
> Nit: Given that you have an "if (devTools)" right below, remove this
conditional
> and init this to nil here and put the other stmt inside the if.

Done.

https://codereview.chromium.org/388803003/diff/70001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/dev_tools_controller.mm:150: [devToolsContainerView_
setDevToolsView: devToolsView withStrategy: strategy];
On 2014/07/15 14:02:19, Alexei Svitkine wrote:
> Nit: Remove spaces after :'s.

Done.

https://codereview.chromium.org/388803003/diff/70001/chrome/browser/ui/cocoa/...
File chrome/browser/ui/cocoa/dev_tools_controller_browsertest.mm (right):

https://codereview.chromium.org/388803003/diff/70001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/dev_tools_controller_browsertest.mm:24: ,
devtools_window_(NULL) {}
On 2014/07/14 11:15:23, jochen wrote:
> please clang-format

Done.

[Alexei Svitkine (slow), 2014-07-15 14:49:10]

lgtm

[jam, 2014-07-16 05:32:14]

On 2014/07/15 06:03:02, dgozman wrote:
> It would be nice to land this top crash fix to the next dev release.
> Adding more reviewers, since Avi is away. 
> jam@ as content owner.
> thakis@, asvitkine@ for chrome/browser/ui/cocoa.

jochen is a content owner as well. not sure why you added him and me?

can you get a mac dev (if avi is gone, then anyone of shess/mark/rsesek). then
an owner  in content can rubberstamp

[dgozman, 2014-07-16 05:48:45]

On 2014/07/16 05:32:14, jam wrote:
> On 2014/07/15 06:03:02, dgozman wrote:
> > It would be nice to land this top crash fix to the next dev release.
> > Adding more reviewers, since Avi is away. 
> > jam@ as content owner.
> > thakis@, asvitkine@ for chrome/browser/ui/cocoa.
> 
> jochen is a content owner as well. not sure why you added him and me?
> 
> can you get a mac dev (if avi is gone, then anyone of shess/mark/rsesek). then
> an owner  in content can rubberstamp

I've already got lgtm from asvitkine, who is mentioned in
chrome/browser/ui/cocoa/OWNERS.
Sorry, but Jochen said he can't review this.

[jochen (gone - plz use gerrit), 2014-07-16 08:49:29]

On 2014/07/16 at 05:48:45, dgozman wrote:
> On 2014/07/16 05:32:14, jam wrote:
> > On 2014/07/15 06:03:02, dgozman wrote:
> > > It would be nice to land this top crash fix to the next dev release.
> > > Adding more reviewers, since Avi is away. 
> > > jam@ as content owner.
> > > thakis@, asvitkine@ for chrome/browser/ui/cocoa.
> > 
> > jochen is a content owner as well. not sure why you added him and me?
> > 
> > can you get a mac dev (if avi is gone, then anyone of shess/mark/rsesek).
then
> > an owner  in content can rubberstamp
> 
> I've already got lgtm from asvitkine, who is mentioned in
chrome/browser/ui/cocoa/OWNERS.
> Sorry, but Jochen said he can't review this.

I basically meant to say the same as jam: I'm not a mac person.

If asvitkine also reviewed the content parts (and given that this code will go
away soon, right?) then lgtm

[dgozman, 2014-07-16 09:18:13]

> I basically meant to say the same as jam: I'm not a mac person.
Sorry for confusion, I've included mac reviewer from the start. None of them is
content owner (except avi), so I've included you to stamp.

> If asvitkine also reviewed the content parts (and given that this code will go
> away soon, right?) then lgtm
Yes, this will go away as soon as crbug.com/392031 is resolved. Not sure when
that will be though.

[dgozman, 2014-07-16 13:43:23]

The CQ bit was checked by dgozman@chromium.org

[commit-bot: I haz the power, 2014-07-16 13:43:54]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dgozman@chromium.org/388803003/90001

[commit-bot: I haz the power, 2014-07-16 22:39:51]

Change committed as 283553