Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Unified Diff: content/browser/web_contents/web_contents_view.h

Issue 388803003: [Mac] Replace SetOverlayView with AllowOtherViews. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebased, fixed comments Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/web_contents/web_contents_view.h
diff --git a/content/browser/web_contents/web_contents_view.h b/content/browser/web_contents/web_contents_view.h
index b2eb5090138ba95c9895357ffa3d12ad2c5b131e..f4a6814cd389351f04945eb6e3c660f2fa85d878 100644
--- a/content/browser/web_contents/web_contents_view.h
+++ b/content/browser/web_contents/web_contents_view.h
@@ -113,14 +113,12 @@ class WebContentsView {
// Returns true if overlapping views are allowed, false otherwise.
virtual bool GetAllowOverlappingViews() const = 0;
- // To draw two overlapping web contents view, the underlaying one should
- // know about the overlaying one. Caller must ensure that |overlay| exists
- // until |RemoveOverlayView| is called.
- virtual void SetOverlayView(WebContentsView* overlay,
- const gfx::Point& offset) = 0;
-
- // Removes the previously set overlay view.
- virtual void RemoveOverlayView() = 0;
+ // Allowing other views disables optimizations which assume that only a single
+ // WebContents is present.
+ virtual void SetAllowOtherViews(bool allow) = 0;
+
+ // Returns true if other views are allowed, false otherwise.
+ virtual bool GetAllowOtherViews() const = 0;
// If we close the tab while a UI control is in an event-tracking
// loop, the control may message freed objects and crash.
« no previous file with comments | « content/browser/web_contents/web_contents_impl.cc ('k') | content/browser/web_contents/web_contents_view_guest.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698