platform_tools/android/bin/gyp_to_android.py - Issue 388693003: Alphabetize defines in generated SkUserConfig.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: platform_tools/android/bin/gyp_to_android.py

Issue 388693003: Alphabetize defines in generated SkUserConfig. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Respond to comments. ordered_set -> defines in test. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: platform_tools/android/bin/gyp_to_android.py

diff --git a/platform_tools/android/bin/gyp_to_android.py b/platform_tools/android/bin/gyp_to_android.py

index 2f2b24d4fd52293a96e22c35417255d31f213049..8083785744e61a68c49e5d1e0725b1c4f0b1a082 100755

--- a/platform_tools/android/bin/gyp_to_android.py

+++ b/platform_tools/android/bin/gyp_to_android.py

@@ -129,7 +129,7 @@ def main(target_dir=None, require_sk_user_config=False):

generate_user_config.generate_user_config(

original_sk_user_config=user_config,

require_sk_user_config=require_sk_user_config, target_dir=dst_dir,

- ordered_set=common.DEFINES)

+ defines=common.DEFINES)

tool_makefile_writer.generate_tool(gyp_dir=tmp_folder,

target_file='tests.gyp',

« no previous file with comments | « no previous file | platform_tools/android/gyp_gen/generate_user_config.py » ('j') | no next file with comments »