Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Side by Side Diff: platform_tools/android/bin/gyp_to_android.py

Issue 388693003: Alphabetize defines in generated SkUserConfig. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Respond to comments. ordered_set -> defines in test. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | platform_tools/android/gyp_gen/generate_user_config.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/python 1 #!/usr/bin/python
2 2
3 # Copyright 2014 Google Inc. 3 # Copyright 2014 Google Inc.
4 # 4 #
5 # Use of this source code is governed by a BSD-style license that can be 5 # Use of this source code is governed by a BSD-style license that can be
6 # found in the LICENSE file. 6 # found in the LICENSE file.
7 7
8 """ 8 """
9 Script for generating the Android framework's version of Skia from gyp 9 Script for generating the Android framework's version of Skia from gyp
10 files. 10 files.
(...skipping 111 matching lines...) Expand 10 before | Expand all | Expand 10 after
122 # Create SkUserConfig 122 # Create SkUserConfig
123 user_config = os.path.join(SKIA_DIR, 'include', 'config', 'SkUserConfig.h') 123 user_config = os.path.join(SKIA_DIR, 'include', 'config', 'SkUserConfig.h')
124 if target_dir: 124 if target_dir:
125 dst_dir = target_dir 125 dst_dir = target_dir
126 else: 126 else:
127 dst_dir = os.path.join(SKIA_DIR, 'include', 'core') 127 dst_dir = os.path.join(SKIA_DIR, 'include', 'core')
128 128
129 generate_user_config.generate_user_config( 129 generate_user_config.generate_user_config(
130 original_sk_user_config=user_config, 130 original_sk_user_config=user_config,
131 require_sk_user_config=require_sk_user_config, target_dir=dst_dir, 131 require_sk_user_config=require_sk_user_config, target_dir=dst_dir,
132 ordered_set=common.DEFINES) 132 defines=common.DEFINES)
133 133
134 tool_makefile_writer.generate_tool(gyp_dir=tmp_folder, 134 tool_makefile_writer.generate_tool(gyp_dir=tmp_folder,
135 target_file='tests.gyp', 135 target_file='tests.gyp',
136 skia_trunk=target_dir, 136 skia_trunk=target_dir,
137 dest_dir='tests', 137 dest_dir='tests',
138 skia_lib_var_dict=common, 138 skia_lib_var_dict=common,
139 local_module_name='skia_test', 139 local_module_name='skia_test',
140 local_module_tags=['tests'], 140 local_module_tags=['tests'],
141 desired_targets=['tests']) 141 desired_targets=['tests'])
142 142
(...skipping 57 matching lines...) Expand 10 before | Expand all | Expand 10 after
200 'arm64')) 200 'arm64'))
201 201
202 makefile_writer.write_android_mk(target_dir=target_dir, 202 makefile_writer.write_android_mk(target_dir=target_dir,
203 common=common, deviations_from_common=deviations_from_common) 203 common=common, deviations_from_common=deviations_from_common)
204 204
205 finally: 205 finally:
206 shutil.rmtree(tmp_folder) 206 shutil.rmtree(tmp_folder)
207 207
208 if __name__ == '__main__': 208 if __name__ == '__main__':
209 main() 209 main()
OLDNEW
« no previous file with comments | « no previous file | platform_tools/android/gyp_gen/generate_user_config.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698