Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 388693003: Alphabetize defines in generated SkUserConfig. (Closed)

Created:
6 years, 5 months ago by scroggo
Modified:
6 years, 5 months ago
Reviewers:
mtklein
CC:
reviews_skia.org, reed1
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Alphabetize defines in generated SkUserConfig. When generating SkUserConfig.h for Android, alphabetize the defines. This will make one merge much harder to look at, but every following one much easier. Committed: https://skia.googlesource.com/skia/+/24b04fa2adc284f21bdfde16d65e9fd2a72f0c2e

Patch Set 1 #

Total comments: 2

Patch Set 2 : Respond to comments. ordered_set -> defines in test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -10 lines) Patch
M platform_tools/android/bin/gyp_to_android.py View 1 chunk +1 line, -1 line 0 comments Download
M platform_tools/android/gyp_gen/generate_user_config.py View 3 chunks +3 lines, -4 lines 0 comments Download
M platform_tools/android/tests/expectations/SkUserConfig-h.txt View 1 chunk +1 line, -1 line 0 comments Download
M platform_tools/android/tests/expectations/missing-filename.xxx View 1 chunk +1 line, -1 line 0 comments Download
M platform_tools/android/tests/generate_user_config_tests.py View 1 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
scroggo
6 years, 5 months ago (2014-07-14 15:35:32 UTC) #1
mtklein
lgtm https://codereview.chromium.org/388693003/diff/1/platform_tools/android/tests/generate_user_config_tests.py File platform_tools/android/tests/generate_user_config_tests.py (right): https://codereview.chromium.org/388693003/diff/1/platform_tools/android/tests/generate_user_config_tests.py#newcode58 platform_tools/android/tests/generate_user_config_tests.py:58: ordered_set = [ 'define' ] -> defines?
6 years, 5 months ago (2014-07-14 16:29:22 UTC) #2
scroggo
https://codereview.chromium.org/388693003/diff/1/platform_tools/android/tests/generate_user_config_tests.py File platform_tools/android/tests/generate_user_config_tests.py (right): https://codereview.chromium.org/388693003/diff/1/platform_tools/android/tests/generate_user_config_tests.py#newcode58 platform_tools/android/tests/generate_user_config_tests.py:58: ordered_set = [ 'define' ] On 2014/07/14 16:29:22, mtklein ...
6 years, 5 months ago (2014-07-14 17:06:52 UTC) #3
scroggo
The CQ bit was checked by scroggo@google.com
6 years, 5 months ago (2014-07-14 17:06:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/scroggo@google.com/388693003/20001
6 years, 5 months ago (2014-07-14 17:07:20 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-14 17:22:06 UTC) #6
Message was sent while issue was closed. 
Change committed as 24b04fa2adc284f21bdfde16d65e9fd2a72f0c2e

Powered by Google App Engine
This is Rietveld 408576698