Rotation into Video Layer + Content Transform

cc/layers/video_layer.cc

Index: cc/layers/video_layer.cc
diff --git a/cc/layers/video_layer.cc b/cc/layers/video_layer.cc
index 4ddfdae69a64f9f4514b7d18be20d1083ba7a1fe..00f2a07fba7883d5146ee017868299da5bd3eee0 100644
--- a/cc/layers/video_layer.cc
+++ b/cc/layers/video_layer.cc
@@ -19,7 +19,10 @@ VideoLayer::VideoLayer(VideoFrameProvider* provider) : provider_(provider) {
 VideoLayer::~VideoLayer() {}
 
 scoped_ptr<LayerImpl> VideoLayer::CreateLayerImpl(LayerTreeImpl* tree_impl) {
-  return VideoLayerImpl::Create(tree_impl, id(), provider_).PassAs<LayerImpl>();
+  scoped_ptr<VideoLayerImpl> impl =
+      VideoLayerImpl::Create(tree_impl, id(), provider_);
+  impl->set_video_rotation(video_rotation_);

[enne (OOO), 2014/07/21 23:42:49]

This should be set during PushProperties.

[suderman, 2014/07/22 00:05:20]

I am willing to make this change however it has moved in and out of push
properties previously (I was asked to add it to push properties then remove it)
so once everything else is sorted out, if we decide to move it to push
properties, I will make that change.

[enne (OOO), 2014/07/22 21:10:39]

Yeah, I disagree with what Dana said.  video_rotation either needs to be an
immutable constructor parameter or a mutable property that is pushed during push
properties.  Right now this code makes it look like a mutable property that's
set in the wrong place.

Can a video change source, reuse the same layer, and have a different rotation?

[suderman, 2014/07/22 21:48:16]

If the video source changes it's metadata will still be processed by the
webmediaplayer making the rotation data set. However even though it doesn't
change moving video_rotation to push_properties groups similar data.

+  return impl.PassAs<LayerImpl>();
 }
 
 bool VideoLayer::Update(ResourceUpdateQueue* queue,